Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new CodableWithConfiguration conformance of AccountDetails #41

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Aug 28, 2024

Support new CodableWithConfiguration conformance of AccountDetails

♻️ Current situation & Problem

This PR updates to the latest SpeziAccount release that migrated AccountDetails to adopt the new CodableWithConfiguration protocols replacing the previous userInfo-based approach of passing additional configuration for encoding and decoding.

⚙️ Release Notes

  • Update to the new SpeziAccount beta release.

📚 Documentation

--

✅ Testing

Existing unit tests cover these modifications.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg
Copy link
Member Author

Supereg commented Aug 28, 2024

The Firestore SDK currently doesn't support CodableWithConfiguration. We tracked this feature request in firebase/firebase-ios-sdk#13552.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the issue in the Firebase project & thanks for adding the workaround here 🚀

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (7855a91) to head (e200594).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   66.24%   66.61%   +0.37%     
==========================================
  Files          19       19              
  Lines        1087     1087              
==========================================
+ Hits          720      724       +4     
+ Misses        367      363       -4     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7855a91...e200594. Read the comment docs.

@Supereg Supereg merged commit 12e7b77 into main Aug 29, 2024
8 checks passed
@Supereg Supereg deleted the feature/codable-with-configuration branch August 29, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants