Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Setting Data When No Data is Provided #40

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Jul 26, 2024

Avoid Setting Data when no Data is Provided

♻️ Current situation & Problem

  • SpeziFirebase tries to write a document when no data should be created which can clash with possible security rules not allowing deletion.
  • No document should be created on updating elements.

⚙️ Release Notes

  • Avoid Setting Data When No Data is Provided

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label Jul 26, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.02%. Comparing base (67981d0) to head (488fba3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   63.02%   63.02%           
=======================================
  Files          19       19           
  Lines        1122     1122           
=======================================
  Hits          707      707           
  Misses        415      415           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67981d0...488fba3. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit e381b7d into main Jul 26, 2024
8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/improveSetup branch July 26, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant