Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SpeziNetworking 2.0 #8

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 10, 2024

Migrate to SpeziNetworking 2.0

♻️ Current situation & Problem

This PR migrates SpeziFileFormats to use the newest release of ByteCoding as part of SpeziNetworking 2.0.

⚙️ Release Notes

  • Migrate to new SpeziNetworking 2.0 release.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5313d1f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   70.64%           
=======================================
  Files           ?       15           
  Lines           ?      630           
  Branches        ?        0           
=======================================
  Hits            ?      445           
  Misses          ?      185           
  Partials        ?        0           
Files Coverage Δ
Sources/EDFFormat/GenericFileWriter.swift 93.44% <100.00%> (ø)
Sources/EDFFormat/Information/FileFormat.swift 94.12% <100.00%> (ø)
...DFFormat/Information/RecordingIdentification.swift 93.34% <100.00%> (ø)
.../EDFFormat/Information/SubjectIdentification.swift 94.88% <100.00%> (ø)
Sources/EDFFormat/Signal/Channel.swift 100.00% <100.00%> (ø)
Sources/EDFFormat/Signal/DataRecord.swift 100.00% <100.00%> (ø)
Sources/EDFFormat/Signal/Signal.swift 100.00% <100.00%> (ø)
Sources/EDFFormat/Signal/Sample.swift 50.00% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5313d1f...0083bc1. Read the comment docs.

@Supereg Supereg mentioned this pull request Jun 20, 2024
1 task
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg; looks great. Sorry for missing this when creating #9!

@Supereg Supereg merged commit c235d5c into main Jun 21, 2024
10 checks passed
@Supereg Supereg deleted the feature/migrate-byte-coding branch June 21, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants