Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed procedure dates #14

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Fixed procedure dates #14

merged 6 commits into from
Dec 11, 2023

Conversation

AdritRao
Copy link
Member

@AdritRao AdritRao commented Dec 5, 2023

Fixing procedure dates

♻️ Current situation & Problem

Not all procedures had dates being extracted from the JSON resources. Without all of the dates being sent to the LLM, it cannot understand the full context and timeline of the patients procedures.

⚙️ Release Notes

The only change in this PR was made in FHIRResource.swift. The modification ensures that the end date of the procedure is taken in each of the resources (which is consistent between DSTU2 and R4).

if case let .period(period) = procedure.performed {
    return try? period.end?.value?.asNSDate()
}

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #14 (2354244) into main (d60882b) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 2354244 differs from pull request most recent head cb43cae. Consider uploading reports for the commit cb43cae to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   46.15%   46.15%           
=======================================
  Files          19       19           
  Lines        1205     1205           
=======================================
  Hits          556      556           
  Misses        649      649           
Files Coverage Δ
Sources/SpeziFHIR/FHIRResource/FHIRResource.swift 14.05% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60882b...cb43cae. Read the comment docs.

@PSchmiedmayer PSchmiedmayer self-assigned this Dec 11, 2023
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 11, 2023
@PSchmiedmayer PSchmiedmayer marked this pull request as ready for review December 11, 2023 07:59
@PSchmiedmayer PSchmiedmayer merged commit 07c2e56 into main Dec 11, 2023
5 checks passed
@PSchmiedmayer PSchmiedmayer deleted the procedure_date branch December 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants