Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift to SpeziLLM #44

Merged
merged 10 commits into from
Feb 26, 2024
Merged

Lift to SpeziLLM #44

merged 10 commits into from
Feb 26, 2024

Conversation

philippzagar
Copy link
Contributor

@philippzagar philippzagar commented Jan 22, 2024

Lift to SpeziLLM

♻️ Current situation & Problem

Dependent on old version of SpeziLLM

⚙️ Release Notes

  • Update to SpeziLLM version 0.7.0

📚 Documentation

Proper docs included

✅ Testing

All tests passing

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: Patch coverage is 43.82716% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 50.50%. Comparing base (5cd5451) to head (25882c1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
+ Coverage   38.55%   50.50%   +11.95%     
===========================================
  Files          30       19       -11     
  Lines        1362      711      -651     
===========================================
- Hits          525      359      -166     
+ Misses        837      352      -485     
Files Coverage Δ
LLMonFHIR/LLMonFHIR.swift 100.00% <ø> (ø)
LLMonFHIR/LLMonFHIRDelegate.swift 100.00% <100.00%> (ø)
LLMonFHIR/LLMonFHIRStandard.swift 8.70% <ø> (ø)
LLMonFHIR/Onboarding/Disclaimer.swift 100.00% <ø> (+8.58%) ⬆️
LLMonFHIR/Onboarding/HealthKitPermissions.swift 95.24% <ø> (+6.35%) ⬆️
LLMonFHIR/Onboarding/OnboardingFlow.swift 100.00% <ø> (+21.43%) ⬆️
LLMonFHIR/Onboarding/OpenAIAPIKey.swift 100.00% <100.00%> (ø)
LLMonFHIR/Onboarding/Welcome.swift 100.00% <ø> (+7.70%) ⬆️
LLMonFHIR/ResourceView.swift 92.00% <92.00%> (ø)
...HIR/FHIR Views/FHIRResourcesInstructionsView.swift 90.91% <90.91%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd5451...25882c1. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates! I took a look at the changes and added some comments here and there about suggestion improvements.

Excited to see this moving up the hierarchy of projects and to see the LLM advancements showing up in LLM on FHIR; great job @philippzagar! 🚀

LLMonFHIR/FHIR Display/InspectResourceView.swift Outdated Show resolved Hide resolved
LLMonFHIR/FHIR Display/MultipleResourcesChatView.swift Outdated Show resolved Hide resolved
LLMonFHIR/FHIR Display/MultipleResourcesChatView.swift Outdated Show resolved Hide resolved
LLMonFHIR.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@philippzagar philippzagar self-assigned this Feb 26, 2024
@philippzagar philippzagar added the enhancement New feature or request label Feb 26, 2024
@philippzagar philippzagar marked this pull request as ready for review February 26, 2024 07:12
@philippzagar
Copy link
Contributor Author

@PSchmiedmayer This PR can be merged after StanfordSpezi/SpeziFHIR#17 is merged and the dependency within LLMonFHIR is updated to the tagged release 🚀

@philippzagar philippzagar merged commit b1ed46c into main Feb 26, 2024
6 checks passed
@philippzagar philippzagar deleted the feat/lift-to-spezillm branch February 26, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants