Bump axios to latest, remove extraneous import and change the code ar…

…ound error a bit (#52)
StalemateInc · Jul 10, 2023 · 1897c9a · 1897c9a
1 parent d3fb434
commit 1897c9a
Show file tree

Hide file tree

Showing 7 changed files with 92 additions and 83 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/licenses.txt b/dist/licenses.txt
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,7 +26,7 @@
   "license": "MIT",
   "dependencies": {
     "@actions/core": "^1.10.0",
-    "axios": "^0.27.2"
+    "axios": "^1.4.0"
   },
   "devDependencies": {
     "@types/jest": "^29.5.3",

diff --git a/src/api.ts b/src/api.ts
@@ -22,7 +22,7 @@ export class API {
 
       return response.data
     } catch (error: unknown) {
-      return Promise.reject(toMoreDescriptiveError(error))
+      throw toMoreDescriptiveError(error)
     }
   }
 
@@ -38,7 +38,7 @@ export class API {
 
       return response.data
     } catch (error: unknown) {
-      return Promise.reject(toMoreDescriptiveError(error))
+      throw toMoreDescriptiveError(error)
     }
   }
 
@@ -61,7 +61,7 @@ export class API {
 
       return response.data
     } catch (error: unknown) {
-      return Promise.reject(toMoreDescriptiveError(error))
+      throw toMoreDescriptiveError(error)
     }
   }
 
@@ -74,7 +74,7 @@ export class API {
 
       return response.data
     } catch (error: unknown) {
-      return Promise.reject(toMoreDescriptiveError(error))
+      throw toMoreDescriptiveError(error)
     }
   }
 

diff --git a/src/main.ts b/src/main.ts
@@ -86,9 +86,12 @@ async function run(): Promise<void> {
         info(DebugMessages.TICKET_ADDED_TO_VERSION(ticket, version.id))
       }
     }
-  } catch (_e) {
-    const e: Error = _e as Error
-    setFailed(e)
+  } catch (e: unknown) {
+    if (e instanceof Error) {
+      setFailed(e.message)
+    } else {
+      setFailed(String(e))
+    }
   }
 }
 

diff --git a/src/utils.ts b/src/utils.ts
@@ -1,11 +1,7 @@
 import { debug } from '@actions/core'
-import axios, { AxiosError } from 'axios'
+import { isAxiosError } from 'axios'
 import { ErrorResponse } from './types'
 
-const isAxiosError = <ResponseType>(error: unknown): error is AxiosError<ResponseType> => {
-  return axios.isAxiosError(error)
-}
-
 export const toMoreDescriptiveError = (error: unknown): Error | unknown => {
   if (
     isAxiosError<ErrorResponse>(error) &&