Cb lang #24
Merged
Cb lang #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Warning Rate Limit Exceeded@maehr has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 59 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on enhancing the multilingual capabilities of the site. By dynamically updating text elements like button labels, search results, and error messages based on the site's language settings, these changes aim to provide a more localized and user-friendly experience. Additionally, modifications include updating UI elements to reflect accurate translations and improving consistency in displayed information. Changes
Related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
_config.ymlis excluded by:!**/*.yml_data/translations.ymlis excluded by:!**/*.yml
Files selected for processing (44)
- _includes/cb/credits.html (1 hunks)
- _includes/collection-banner.html (1 hunks)
- _includes/data-download-modal.html (1 hunks)
- _includes/feature/audio.html (1 hunks)
- _includes/feature/image.html (1 hunks)
- _includes/feature/nav-menu.html (1 hunks)
- _includes/feature/pdf.html (1 hunks)
- _includes/feature/video.html (1 hunks)
- _includes/footer.html (2 hunks)
- _includes/head/head.html (1 hunks)
- _includes/index/data-download.html (1 hunks)
- _includes/index/description.html (1 hunks)
- _includes/index/objects.html (1 hunks)
- _includes/index/time.html (1 hunks)
- _includes/item/3d-model-viewer.html (1 hunks)
- _includes/item/audio-player.html (1 hunks)
- _includes/item/breadcrumbs.html (1 hunks)
- _includes/item/browse-buttons.html (1 hunks)
- _includes/item/child/audio-player.html (1 hunks)
- _includes/item/child/citation-box.html (1 hunks)
- _includes/item/child/compound-item-download-buttons.html (1 hunks)
- _includes/item/child/compound-item-modal-gallery.html (2 hunks)
- _includes/item/child/download-buttons.html (1 hunks)
- _includes/item/child/image-gallery.html (1 hunks)
- _includes/item/child/rights-box.html (1 hunks)
- _includes/item/child/video-player.html (1 hunks)
- _includes/item/citation-box.html (1 hunks)
- _includes/item/download-buttons.html (1 hunks)
- _includes/item/image-gallery.html (1 hunks)
- _includes/item/pdf-embed.html (1 hunks)
- _includes/item/rights-box.html (1 hunks)
- _includes/item/video-player.html (1 hunks)
- _includes/js/browse-js.html (1 hunks)
- _includes/js/map-js.html (1 hunks)
- _includes/js/table-js.html (2 hunks)
- _includes/nav-search-lunr.html (1 hunks)
- _includes/scroll-to-top.html (1 hunks)
- _layouts/browse.html (2 hunks)
- _layouts/data.html (1 hunks)
- _layouts/default.html (1 hunks)
- _layouts/home-infographic.html (1 hunks)
- _layouts/item/item-page-base.html (1 hunks)
- _layouts/item/item-page-full-width.html (1 hunks)
- _layouts/search.html (2 hunks)
Additional comments: 57
_includes/index/description.html (2)
- 3-3: The dynamic fetching of the title based on the site's language setting is implemented correctly. It uses a fallback to "Description" if the translation is not available, which is a good practice for ensuring content availability in case of missing translations.
- 5-5: The dynamic fetching of the "Learn More" button text is correctly implemented, including the use of
»for the arrow symbol. This approach maintains consistency with the original static content while enabling multilingual support._includes/item/child/video-player.html (1)
- 10-10: The implementation for dynamically fetching the fallback message for the video player based on the site's language setting is correct. It also provides a default message in English, which is a good practice for ensuring the message is always available.
_includes/item/audio-player.html (1)
- 9-9: The dynamic fetching of the fallback message and download link text for the audio player is correctly implemented. This approach ensures that the audio player component is fully localized, enhancing the user experience for non-English speakers.
_includes/item/child/audio-player.html (1)
- 9-9: The implementation for dynamically fetching the fallback message and download link text for the child audio player based on the site's language setting is correct. Including a default message ensures that the content is always available, which is a good practice.
_layouts/data.html (1)
- 18-18: The dynamic fetching of the header cell content for the "Link" column in the data table is correctly implemented. This change ensures that the table header is localized, which is an important aspect of providing a fully multilingual user interface.
_includes/item/video-player.html (1)
- 10-10: The implementation for dynamically fetching the error message and download link text for the video player based on the site's language setting is correct. This approach ensures that the video player component is fully localized, enhancing the user experience for non-English speakers.
_layouts/default.html (1)
- 7-7: The dynamic fetching of the "Skip to main content" link text based on the site's language setting is correctly implemented. This is a crucial aspect of accessibility and localization, ensuring that all users, regardless of language, can navigate the site effectively.
_includes/item/child/image-gallery.html (1)
- 9-9: The implementation for dynamically fetching the text displayed below the image in the child image gallery based on the site's language setting is correct. This change ensures that the gallery component is fully localized, enhancing the user experience for non-English speakers.
_includes/item/pdf-embed.html (1)
- 10-10: The dynamic fetching of the fallback text for the PDF embed component based on the site's language setting is correctly implemented. Including a default message ensures that the content is always available, which is a good practice for enhancing user experience across different languages.
_includes/item/image-gallery.html (1)
- 9-9: The implementation for dynamically fetching the text displayed below the image in the image gallery based on the site's language setting is correct. This change ensures that the gallery component is fully localized, enhancing the user experience for non-English speakers.
_includes/item/breadcrumbs.html (1)
- 8-9: The dynamic fetching of the breadcrumb link texts based on the site's language setting is correctly implemented. This approach ensures that the breadcrumb navigation is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/item/citation-box.html (1)
- 7-12: The implementation for dynamically fetching the text for the card headers and data terms in the citation box based on the site's language setting is correct. This change ensures that the citation information is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/item/rights-box.html (1)
- 7-12: The dynamic fetching of the card header and labels in the rights box based on the site's language setting is correctly implemented. This approach ensures that the rights information is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/item/child/citation-box.html (1)
- 7-12: The implementation for dynamically fetching the text for the card headers and data terms in the child item's citation box based on the site's language setting is correct. This change ensures that the citation information for child items is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/item/child/rights-box.html (1)
- 7-12: The dynamic fetching of the card header and rights-related content in the child item's rights box based on the site's language setting is correctly implemented. This approach ensures that the rights information for child items is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_layouts/home-infographic.html (1)
- 11-20: The implementation for dynamically fetching the titles of included components based on the site's language setting in the home infographic layout is correct. This change ensures that the titles for "Sample Items," "Top Subjects," and "Locations" are fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/scroll-to-top.html (1)
- 19-19: The dynamic fetching of the
titleandaria-labelattributes for the "Back to Top" button based on the site's language setting is correctly implemented. This is a crucial aspect of accessibility and localization, ensuring that all users, regardless of language, can understand the button's purpose._includes/nav-search-lunr.html (1)
- 12-12: The implementation for dynamically fetching the visually-hidden text for the search button based on the site's language setting is correct. This change ensures that the search functionality is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/index/time.html (1)
- 11-13: The dynamic fetching of the card title and button text in the time component based on the site's language setting is correctly implemented. This change ensures that the time span information and the "View Timeline" button are fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/feature/nav-menu.html (1)
- 16-16: The implementation for dynamically fetching the text for the navigation menu items based on the site's language setting is correct. This change ensures that the navigation menu is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_includes/js/table-js.html (1)
- 11-11: The conditional inclusion of language-specific DataTables configuration based on the
langvariable is correctly implemented. This approach ensures that the DataTables functionality is fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website._layouts/item/item-page-full-width.html (1)
- 14-15: The dynamic fetching of the button text and its associated tooltip in the item page full-width layout based on the site's language setting is correctly implemented. This change ensures that the button and tooltip are fully localized, enhancing the user experience for non-English speakers and contributing to a more accessible website.
_layouts/item/item-page-base.html (1)
- 13-14: The implementation of dynamic text for the link based on the site's language setting is a good approach for supporting multilingual content. Ensure that the
site.langvariable is always correctly set and has a valid value to prevent any issues with missing translations._includes/item/3d-model-viewer.html (1)
- 38-38: The dynamic loading of button text based on the site's language setting is a great enhancement for user experience in a multilingual context. Ensure that the translation data source is consistently maintained and covers all languages supported by the site.
_includes/cb/credits.html (1)
- 3-12: Replacing hardcoded text with dynamic content from translation data in the Technical Credits section is a commendable effort towards supporting multilingual content. Ensure that translations are accurate and that the default fallbacks are appropriate for a broad audience.
_includes/feature/audio.html (1)
- 34-34: Replacing the static error message with a dynamic, localized message based on the site's language setting is an excellent improvement for user experience. Ensure that the translation data source includes entries for all languages supported by the site to maintain consistency across different locales.
_includes/item/child/compound-item-download-buttons.html (1)
- 10-16: Dynamically updating the text displayed on buttons based on the site's language setting is a significant improvement for multilingual support. Ensure that the translation data source is consistently maintained and accurately reflects all supported languages.
_includes/head/head.html (1)
- 16-16: Updating the
Content-Languagemeta tag to use a dynamic value fromsite.langis a best practice for multilingual websites. Ensure that thesite.langvariable is always correctly set and has a valid value to prevent any issues with incorrect language settings._includes/footer.html (1)
- 33-39: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [36-48]
Updating the footer text to use dynamic translations for "built with" and "Last updated" based on the site's language setting is a valuable enhancement for multilingual support. Ensure that translations are accurate and comprehensive for all supported languages.
_includes/collection-banner.html (1)
- 31-31: Updating the text displayed in the banner link to use dynamic translations based on the site's language setting is a good practice for enhancing multilingual support. Ensure that the translation data source is consistently maintained and accurately reflects all supported languages.
_layouts/browse.html (1)
- 10-30: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [13-38]
Dynamically updating placeholders and button text on the browse page based on the site's language setting is an excellent enhancement for multilingual support. Ensure that the translation data source is consistently maintained and covers all languages supported by the site.
_includes/feature/pdf.html (1)
- 38-39: Updating the error message for PDF rendering failures to be language-specific and providing a direct download link is a significant improvement for user experience in a multilingual context. Ensure that the translation data source includes entries for all languages supported by the site to maintain consistency across different locales.
_includes/index/data-download.html (1)
- 4-25: Dynamically generating text for various data download button labels based on the site's language setting is an excellent enhancement for multilingual support. Ensure that the translation data source is consistently maintained and accurately reflects all supported languages.
_includes/item/browse-buttons.html (1)
- 9-11: The implementation of dynamic language translations for the navigation buttons ("Previous", "Back to Browse", "Next") is correctly done using the site's language setting and translation data. This approach enhances the user experience for non-English speakers by providing localized navigation options. Ensure that the translation keys used here are correctly defined in the translation data files to avoid missing translations.
_includes/item/child/download-buttons.html (1)
- 14-17: The dynamic updates to the button labels for "View on Timeline," "View on Map," "View on Vimeo," "View on YouTube," and "Link to Object" are correctly implemented using the site's language setting and translation data. This approach ensures that users can interact with the site in their preferred language, improving accessibility and user experience. Make sure the translation keys are accurately defined in the translation data files.
_includes/item/download-buttons.html (1)
- 12-18: The dynamic updates to the button labels for viewing transcripts, timelines, maps, Vimeo, YouTube, and downloading content are correctly implemented using the site's language setting and translation data. This ensures a localized user experience across different parts of the site. It's important to verify that all translation keys are accurately defined in the translation data files to prevent any missing translations.
_layouts/search.html (2)
- 8-23: The dynamic updates to the button text, modal titles, and descriptive text within the modal body for search options are correctly implemented using the site's language setting and translation data. This enhances the search functionality by providing localized instructions and options, improving the user experience for non-English speakers. Ensure that all translation keys are correctly defined in the translation data files.
- 46-47: The footer text about search engines being powered by Lunr.js and the alternative Google CSE search option are also made translatable, which is a good practice for maintaining consistency in the localized user experience across the site. Verify that the translation keys for these sections are accurately defined in the translation data files.
_includes/feature/video.html (1)
- 52-52: Replacing the static error message with a dynamic, language-specific one for the video element is a significant improvement for non-English speakers. This ensures that users receive localized feedback when their browser does not support the video element. Confirm that the translation key for the error message is correctly defined in the translation data files.
_includes/index/objects.html (1)
- 5-33: The dynamic updates to the displayed text for different object types (image, audio, video, pdf, panorama, record, compound object, multiple) using translated strings are correctly implemented. This approach enhances the user experience by providing localized content, which is crucial for a multilingual site. Ensure that all translation keys for object types and the "View table" button are accurately defined in the translation data files.
_includes/feature/image.html (1)
- 45-45: Updating the
titleattribute of the<img>tag to dynamically fetch a translation for the tooltip text based on the site's language setting is a thoughtful detail that enhances accessibility and user experience. This ensures that users receive localized tooltips, improving the overall usability of the site. Confirm that the translation key for the tooltip text is correctly defined in the translation data files._includes/js/browse-js.html (1)
- 79-79: The implementation of dynamic translations for the "View Full Record" button is a significant enhancement for multilingual support. However, it's essential to ensure that the
defaultfilter is used correctly and that the translation keys exist in thesite.data.translationsstructure. If the translation for a specific language is missing, it will gracefully fall back to the default text "View Full Record". This approach enhances the user experience by providing localized interface elements._includes/js/map-js.html (1)
- 137-137: The dynamic translation for the "View Item" button in the map's popup template is a valuable addition for supporting multiple languages. This change ensures that users interacting with the map feature receive a localized experience, which is crucial for accessibility and user engagement. It's important to verify that the translation keys are correctly defined in the
site.data.translationsstructure to ensure that the correct text is displayed for each language setting._includes/item/child/compound-item-modal-gallery.html (4)
- 61-61: The update to the
aria-labelattribute for the SVG element with a dynamic translation for "Previous Item" is a thoughtful improvement for accessibility. This change ensures that screen readers can provide a localized description of the button's function, enhancing the user experience for non-English speakers and users with disabilities.- 64-64: The dynamic translation for the "Previous Item" text within the button is correctly implemented. This ensures that users navigating through the modal gallery receive localized text, improving the overall user experience across different languages.
- 75-75: The dynamic translation for the "Next Item" text within the button is correctly implemented, similar to the "Previous Item" button. This consistency in implementing dynamic translations for navigation buttons within the modal gallery ensures a seamless and localized user experience.
- 76-76: The update to the
aria-labelattribute for the SVG element with a dynamic translation for "Next Item" mirrors the improvement made for the "Previous Item" button. This consistency in enhancing accessibility through dynamic translations is commendable, ensuring that all users, regardless of language preference or disabilities, can navigate the modal gallery effectively._includes/data-download-modal.html (9)
- 9-9: The implementation of dynamic button text using translation data is correct and follows best practices for multilingual support in Jekyll sites. This approach ensures that the button text is appropriately localized based on the site's language setting.
- 15-15: The dynamic modal title using translation data is correctly implemented. It enhances the user experience by providing localized titles based on the selected language, adhering to best practices for multilingual websites.
- 19-19: The dynamic description within the modal body is correctly implemented. This change ensures that the description is localized, improving accessibility and user experience for non-English speakers.
- 24-29: The section for downloading complete metadata is correctly updated to include dynamic translations for the title, description, and button labels. This ensures that users can understand the options available in their preferred language, enhancing the site's multilingual capabilities.
- 36-38: The dynamic translations for the metadata facets section are correctly implemented. This change improves the clarity of the options available for downloading metadata facets in the user's preferred language.
- 45-48: The subject metadata section correctly uses dynamic translations for the title, description, and button labels. This ensures that the information is accessible and understandable to users in their preferred language, aligning with the goal of enhancing multilingual support.
- 55-58: The location metadata section is correctly updated to include dynamic translations. This change ensures that users can access and understand the location metadata options in their preferred language, contributing to the site's multilingual capabilities.
- 74-75: The timeline metadata section correctly uses dynamic translations for the title and description. This enhances the user experience by providing localized information about the timeline metadata options.
- 82-84: The source code section is correctly updated to include dynamic translations for the title, description, and button label. This ensures that users can access the source code information in their preferred language, enhancing the site's multilingual support.
|
@koilebeit for bug hunting I set up https://maehr.github.io/collectionbuilder-csv/ |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (4)
_config.ymlis excluded by:!**/*.yml_data/translations.ymlis excluded by:!**/*.ymlassets/lib/datatables/de.jsonis excluded by:!**/*.jsonassets/lib/datatables/es.jsonis excluded by:!**/*.json
Files selected for processing (5)
- _includes/js/browse-js.html (2 hunks)
- _includes/js/table-js.html (1 hunks)
- _layouts/browse.html (2 hunks)
- _layouts/home-infographic.html (1 hunks)
- _layouts/item/item-page-base.html (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- _includes/js/browse-js.html
- _includes/js/table-js.html
- _layouts/browse.html
- _layouts/home-infographic.html
- _layouts/item/item-page-base.html
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
maehr
commented
Feb 19, 2024
forschung.stadtgeschichtebasel.ch/_layouts/timeline.html Lines 26 to 28 in 5c1864d |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
_data/translations.ymlis excluded by:!**/*.yml
Files selected for processing (7)
- _includes/cb/credits.html (1 hunks)
- _includes/data-download-modal.html (1 hunks)
- _includes/feature/nav-menu.html (1 hunks)
- _includes/feature/pdf.html (1 hunks)
- _includes/feature/video.html (1 hunks)
- _includes/index/carousel.html (1 hunks)
- _layouts/timeline.html (3 hunks)
Files skipped from review as they are similar to previous changes (5)
- _includes/cb/credits.html
- _includes/data-download-modal.html
- _includes/feature/nav-menu.html
- _includes/feature/pdf.html
- _includes/feature/video.html
Additional comments: 4
_layouts/timeline.html (3)
- 7-7: The introduction of the
yearsvariable to fetch the translation based on the site's language setting is a good enhancement for multilingual support. Ensure that the translations for 'Years' are correctly set up in the translations file for all supported languages.- 28-28: Updating the button label from "Year" to "years" improves consistency with the newly introduced
yearsvariable. This change aligns well with the objective of enhancing multilingual capabilities. However, ensure that the label is correctly capitalized according to the UI design standards or localization norms.- 39-39: Adjusting the date range display format to include links is a thoughtful UI improvement. It enhances user navigation within the timeline. Ensure that the
uniqueYearsvariable accurately reflects the years available in the timeline data and that the links are functional and lead to the correct sections._includes/index/carousel.html (1)
- 23-23: The update to dynamically fetch the 'btn-text' value based on the site's language setting is a significant improvement for multilingual support. This ensures that the carousel component's button label is correctly localized. Verify that the translations for "View Item" are correctly set up in the translations file for all supported languages and that the fallback to "View Item" works as expected in case a translation is missing.
I fixed all. If you could use the inline comment feature next time https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#starting-a-review GitHub can automate even more steps of the review. |
|
I did some more bug hunting.
|
|
@koilebeit Ready for review. I fixed some more obvious bugs ;) |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
_data/translations.ymlis excluded by:!**/*.yml
Files selected for processing (4)
- _includes/item/image-gallery.html (1 hunks)
- _includes/item/pdf-embed.html (1 hunks)
- _includes/item/rights-box.html (1 hunks)
- _includes/item/video-player.html (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- _includes/item/image-gallery.html
- _includes/item/pdf-embed.html
- _includes/item/rights-box.html
- _includes/item/video-player.html
7 tasks
koilebeit
reviewed
Feb 28, 2024
koilebeit
requested changes
Feb 28, 2024
Co-authored-by: Nico Görlich <[email protected]>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
_data/translations.ymlis excluded by:!**/*.yml
Files selected for processing (1)
- _layouts/timeline.html (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- _layouts/timeline.html
Fixed it
|
koilebeit
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
_data/translations.ymlis excluded by:!**/*.yml
Files selected for processing (4)
- _includes/item/download-buttons.html (1 hunks)
- _includes/js/lunr-js.html (2 hunks)
- _includes/nav-search-lunr.html (1 hunks)
- _layouts/search.html (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- _includes/nav-search-lunr.html
Additional comments: 4
_includes/js/lunr-js.html (2)
- 3-3: The introduction of the
results_foundvariable to dynamically display the number of search results in the UI is a positive change for localization. However, ensure that the translation data is properly sanitized to prevent any potential security risks, especially since it's being inserted directly into the HTML.- 48-48: The dynamic update of the search results count using the
results_foundvariable is correctly implemented. This enhances the user experience by providing localized feedback on the number of search results found. Good job on implementing this feature._includes/item/download-buttons.html (1)
- 12-12: The dynamic update of button labels using translation data is a significant improvement for localization and user experience. Ensure that the translation data is properly sanitized to prevent any potential security risks, especially since it's being inserted directly into the HTML.
Also applies to: 15-15, 17-17, 19-19
_layouts/search.html (1)
- 8-8: The updates to make button text, modal titles, and descriptive text within the modal body language-dependent are well-implemented. These changes significantly enhance the localization and user experience of the search functionality. Ensure that all translation data is properly sanitized to prevent any potential security risks.
Also applies to: 14-14, 15-15, 18-18, 20-23, 35-35, 37-37, 46-46, 47-47
There was a problem hiding this comment.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
_config.ymlis excluded by:!**/*.yml
Files selected for processing (8)
- _includes/feature/audio.html (1 hunks)
- _includes/feature/image.html (1 hunks)
- _includes/feature/pdf.html (1 hunks)
- _includes/feature/video.html (1 hunks)
- _includes/index/carousel.html (1 hunks)
- _includes/item/download-buttons.html (1 hunks)
- _includes/js/map-js.html (1 hunks)
- _layouts/timeline.html (3 hunks)
Files skipped from review as they are similar to previous changes (4)
- _includes/feature/video.html
- _includes/index/carousel.html
- _includes/js/map-js.html
- _layouts/timeline.html
Additional comments: 4
_includes/feature/audio.html (1)
- 34-34: The dynamic error message for the audio element enhances the site's internationalization. This is a positive change that makes the site more accessible to users in different languages.
_includes/feature/pdf.html (1)
- 38-38: The update to provide a localized error message and a direct download link for PDFs enhances user experience by catering to non-English speakers and offering an alternative when PDFs fail to render.
_includes/item/download-buttons.html (1)
- 12-19: Updating button labels dynamically based on language settings is a significant improvement towards making the site more accessible and user-friendly for a global audience.
_includes/feature/image.html (1)
- 45-45: Dynamically fetching a translation for the tooltip text based on the site's language setting is a thoughtful addition to the site's internationalization efforts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Proposed changes
Live https://maehr.github.io/collectionbuilder-csv/
See evaluate using label default in liquid CollectionBuilder/cb-translate#4
See evaluate areas in template where language use should be simplified to support translation CollectionBuilder/cb-translate#5
See Cb translate CollectionBuilder/cb-translate#10
See feat: translations for es and de added CollectionBuilder/cb-translate#7
Types of changes
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation