-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate unit file for st2api, st2auth and st2stream #721
Open
nzlosh
wants to merge
11
commits into
StackStorm:master
Choose a base branch
from
nzlosh:generate_unit_file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7c2dad7
Move api, auth and stream service unit files to generator so st2.conf…
nzlosh 6a0c318
Enable services during post installation on Debian-like systems
nzlosh b7b018a
Enable and start st2api/st2auth/st2stream services on RH based system…
nzlosh a2df9cf
Fix default ports
nzlosh 0854611
drop rpm service files
cognifloyd b162672
rpm helper should not try to install generated service files
cognifloyd 9d49e83
Fix crash when st2.conf doesn't have the expected ini section.
nzlosh 151a3ee
Merge branch 'master' into generate_unit_file
nzlosh b89380c
fix syntax for ConfigParser get().
nzlosh 11c3c76
Remove attempt to restart services via post installation script for R…
nzlosh 08bf806
Merge branch 'master' into generate_unit_file
nzlosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,9 +47,6 @@ override_dh_gencontrol: | |
override_dh_installinit: | ||
dh_systemd_enable --name=st2actionrunner st2actionrunner.service | ||
install -p -m644 debian/[email protected] debian/st2/lib/systemd/system/[email protected] | ||
dh_systemd_enable --name=st2api st2api.service | ||
dh_systemd_enable --name=st2stream st2stream.service | ||
dh_systemd_enable --name=st2auth st2auth.service | ||
dh_systemd_enable --name=st2notifier st2notifier.service | ||
dh_systemd_enable --name=st2rulesengine st2rulesengine.service | ||
dh_systemd_enable --name=st2sensorcontainer st2sensorcontainer.service | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
set -e | ||
|
||
# make sure that our socket generators run | ||
# Reload systemd to run generators for unit and socket files. | ||
systemctl daemon-reload >/dev/null 2>&1 || true | ||
|
||
# Enable services created by systemd generator | ||
systemctl enable st2api st2auth st2stream >/dev/null 2>&1 || true | ||
systemctl start st2api st2auth st2stream >/dev/null 2>&1 || true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the test error for EL distros:
I think this is already handled by the
%post
macro which uses the%service_post
helper. That runs:st2-packages/rpmspec/helpers.spec
Line 86 in 23f100c
What if you remove the output redirection in the
%service_post
macro helper? Then maybe we'll see if there's an error. And maybe remove it here too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a worker timeout for gunicorn on EL7, but I don't think that's the cause of the services failing to start for the RPM based distros. I still don't see any errors in the logs that indicate why the service is not enabled and started.