Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contribution of new py-amqp/asyncio based sensor, bump to v1.2.0 #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ip-sf
Copy link
Contributor

@ip-sf ip-sf commented Jan 24, 2023

A direct result of StackStorm/st2#5743

This new sensor uses only py-amqp and asyncio (3.8), and is tested and working inside the st2sensorcontainer docker image, when ran in either single-sensor-mode or just via a single st2sensorcontainer process.

@ip-sf
Copy link
Contributor Author

ip-sf commented Jan 24, 2023

Unsurprisingly, the Test job failed.

jobs:
  build_and_test:
    runs-on: ubuntu-20.04
    # When parent workflow is named "Build and Test" this shows up as:
    #   "Build and Test / Python 3.6"
    name: 'Python ${{ matrix.python-version-short }}'
    strategy:
      matrix:
        include:
          - python-version-short: "3.6"
            python-version: 3.6.13

Testing via 3.6, Stackstorm running 3.8. asyncio features are 3.8 dependent.

@ip-sf
Copy link
Contributor Author

ip-sf commented Jan 24, 2023

Execution log
execution.log
Screenshot of trigger instance
image

@ip-sf ip-sf changed the title contribution of new py-amqp/asyncio based sensor, bump to v1.1.2 feat: contribution of new py-amqp/asyncio based sensor, bump to v1.1.2 Jan 24, 2023
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing it! Some nicely written code! 👍

We however can't merge it so far as it's failing CI on py3.6 which is still supported by st2 (because we support U18 which comes with py3.6).

As we'll drop py3.6 in the future releases we could merge it later.
But anyways it's something that should be helpful to other folks. Keeping it open.

CHANGES.md Outdated Show resolved Hide resolved
@arm4b arm4b added the feature label Jan 29, 2023
@ip-sf
Copy link
Contributor Author

ip-sf commented Jan 31, 2023

@armab Understood on py3.6. Im not familiar with U18 (and my google-fu is failing me), could you provide a link that lets me learn more? Thanks!

@arm4b
Copy link
Member

arm4b commented Feb 1, 2023

Some of the Python3 support versioning discussions are availble here: StackStorm/community#103 and StackStorm/community#115 (comment)

@ip-sf ip-sf changed the title feat: contribution of new py-amqp/asyncio based sensor, bump to v1.1.2 feat: contribution of new py-amqp/asyncio based sensor, bump to v1.2.0 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants