Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sensor-to-check-if-api-is-down #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jschoewe
Copy link
Contributor

Added sensor to check if the orion API is down and fire a trigger if it is

Copy link
Member

@jjm jjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

pack.yaml Outdated Show resolved Hide resolved
sensors/solarwinds_api_check.py Outdated Show resolved Hide resolved
self._logger.debug("SolarWinds API query successful")
self._logger.debug(orion_data)
except ConnectionError:
self._logger.debug('Dispatch SolarWinds services restart trigger')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not not be a good idea to add a way of disabling these restarts? What if this triggered while you were doing an upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the trigger to solarwinds_api_down because this doesn't restart anything until a rule is made to map the trigger to an action and it can be disabled in that rule.

class_name: "SolarwindsApiCheck"
entry_point: "solarwinds_api_check.py"
description: "Verify that the SolarWinds API is up and accepting connections."
poll_interval: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase this to 60 seconds please.

class_name: "SolarwindsApiCheck"
entry_point: "solarwinds_api_check.py"
description: "Verify that the SolarWinds API is up and accepting connections."
poll_interval: 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschoewe can you increase this polling interval to a higher-value, maybe 15 minutes?

@nmaludy
Copy link
Contributor

nmaludy commented Oct 8, 2020

@jschoewe it looks like there is a mistral workflow that is hanging out in this pack that is breaking testing, can you please convert it to Orquesta using orquestaconvert https://github.com/StackStorm/orquestaconvert

@CLAassistant
Copy link

CLAassistant commented May 11, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants