-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/sensor-to-check-if-api-is-down #24
base: master
Are you sure you want to change the base?
feature/sensor-to-check-if-api-is-down #24
Conversation
merge updates from forked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
sensors/solarwinds_api_check.py
Outdated
self._logger.debug("SolarWinds API query successful") | ||
self._logger.debug(orion_data) | ||
except ConnectionError: | ||
self._logger.debug('Dispatch SolarWinds services restart trigger') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not not be a good idea to add a way of disabling these restarts? What if this triggered while you were doing an upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the trigger to solarwinds_api_down because this doesn't restart anything until a rule is made to map the trigger to an action and it can be disabled in that rule.
sensors/solarwinds_api_check.yaml
Outdated
class_name: "SolarwindsApiCheck" | ||
entry_point: "solarwinds_api_check.py" | ||
description: "Verify that the SolarWinds API is up and accepting connections." | ||
poll_interval: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's increase this to 60 seconds please.
sensors/solarwinds_api_check.yaml
Outdated
class_name: "SolarwindsApiCheck" | ||
entry_point: "solarwinds_api_check.py" | ||
description: "Verify that the SolarWinds API is up and accepting connections." | ||
poll_interval: 60 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jschoewe can you increase this polling interval to a higher-value, maybe 15 minutes?
@jschoewe it looks like there is a mistral workflow that is hanging out in this pack that is breaking testing, can you please convert it to Orquesta using |
Added sensor to check if the orion API is down and fire a trigger if it is