Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ship Movement #3

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Added Ship Movement #3

wants to merge 8 commits into from

Conversation

Shargon-Pendragon
Copy link

@Splyth
Copy link
Owner

Splyth commented Jun 27, 2017 •
edited
Loading

In the future please layout your PR as follows:

  • Stuff I did
  • More Stuff I did

[Tests](My test url here)
Issue

@random_person_to_review

@Splyth
Copy link
Owner

Splyth commented Jun 28, 2017

BTW Needs Testing and Documentation added to your code.

Please checkout here for documentation examples for C#

And here for how to get started with testing.

Code Linters are also a good bet. I think we are going with this one for the moment

Splyth
Splyth requested changes Jun 28, 2017
View reviewed changes
Copy link
Owner

@Splyth Splyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing, docs, and linted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Splyth Splyth Splyth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shargon-Pendragon @Splyth