Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-512] Dependency notations for BumpTech Glide #649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ceNobiteElf
Copy link

Hello/bonjour, I've added dependency notations for Glide.

What?

Resolves #512

Why?

To resolve #512, so that the world can have at least one more nice thing 😄

How?

  • Added a group for BumpTech and a subgroup for Glide, adding all of its modules (minus the tunnel one since that hasn't been maintained in a few years).
  • Added a version key rules file since the Compose and KTX modules don't (yet) follow the same versioning as the other modules.

Testing?

  • Ran check task.
  • Published to local Maven and consumed in the sample projects.
  • Tested all dependencies in sample-android, sample-groovy and sample-kotlin.

Note

After running check I saw 2 lines appearing in the generated files related to the Compose runtime-tracing module. Not sure what that one is about and what to do about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency notations for bumptech/glide
1 participant