Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vspacing_factor as a param for TracesWidget #3461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakeswann1
Copy link
Contributor

@jakeswann1 jakeswann1 commented Oct 3, 2024

It would be useful for me (and maybe others?) to be able to adjust the vertical spacing of traces in the TracesWidget, so I've added a parameter which defaults (as before) to 1.5x max trace amplitude

@jakeswann1 jakeswann1 changed the title Added vspacing_factor as a param for TracesWidget Add vspacing_factor as a param for TracesWidget Oct 3, 2024
@alejoe91 alejoe91 added the widgets Related to widgets module label Oct 3, 2024
Copy link
Collaborator

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opinions from people on tacking this to the end in case of positional arguments? I know we are trying to force people do use keyword, but food for thought?

@alejoe91
Copy link
Member

alejoe91 commented Oct 4, 2024

I think it's on in this case since they are all plotting kwargs. I don't think anyone would use positional to that death! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
widgets Related to widgets module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants