feature/SPRIND-137 #295

zoemaas · 2024-12-06T23:09:55Z

No description provided.

# Conflicts: # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # pnpm-lock.yaml

# Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

into feature/SPRIND-137 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

…/VDX-341 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

into feature/SPRIND-137 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

# Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

…/VDX-341 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

packages/siopv2-oid4vp-op-auth/src/agent/DidAuthSiopOpAuthenticator.ts

…or case sending authentication response

…llenge (did:web support)

…is present

…/VDX-341 # Conflicts: # packages/ebsi-support/package.json # packages/mdl-mdoc/package.json # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-rest-api/package.json # packages/oid4vci-issuer-rest-client/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # packages/siopv2-oid4vp-common/package.json # packages/siopv2-oid4vp-op-auth/package.json # packages/siopv2-oid4vp-op-auth/src/agent/DidAuthSiopOpAuthenticator.ts # packages/siopv2-oid4vp-op-auth/src/services/Siopv2MachineService.ts # packages/siopv2-oid4vp-rp-auth/package.json # packages/siopv2-oid4vp-rp-rest-api/package.json # packages/w3c-vc-api/package.json # pnpm-lock.yaml

sanderPostma

The OP side code has to be removed as that code does not work and has to be re-done as part of SPRIND-150.
We not have support for creating DCQL presentations

sanderPostma · 2025-01-17T11:26:11Z

packages/siopv2-oid4vp-op-auth/src/services/Siopv2MachineService.ts

+      // todo: Change issuer value in case we do not use identifier. Use key.meta.jwkThumbprint then
+      responseSignerOpts: idOpts!,
+    })
+  } else if (request.dcqlQuery) {


Integration attempts were supposed to be removed from this PR.
We haven no code to create a presentation from DCQL (see SPRIND-150)

sanderPostma · 2025-01-17T11:28:34Z

packages/siopv2-oid4vp-op-auth/src/agent/DidAuthSiopOpAuthenticator.ts


-    if (verifiableCredentialsWithDefinition.length === 0) {
-      return Promise.reject(Error('None of the selected credentials match any of the presentation definitions.'))
+    } else if (authorizationRequestData.dcqlQuery) {


Integration attempts were supposed to be removed from this PR.
We haven no code to create a presentation from DCQL (see SPRIND-150), you can't just drop raw credentials on there.

packages/siopv2-oid4vp-op-auth/package.json

packages/siopv2-oid4vp-op-auth/src/types/IDidAuthSiopOpAuthenticator.ts

ronal2do

I think all comments has been addressed, lets carifully test everything, in case of new issue, handle it in a new ticket/PR

# Conflicts: # packages/siopv2-oid4vp-rp-rest-api/src/siop-api-functions.ts

fix: Updated dependencies and fixed broken code

4982faa

zoemaas self-assigned this Dec 6, 2024

zoemaas added 5 commits December 8, 2024 00:46

Merge branch 'develop' into feature/SPRIND-137

d5ccb83

# Conflicts: # packages/oid4vci-holder/package.json # packages/oid4vci-issuer-store/package.json # packages/oid4vci-issuer/package.json # pnpm-lock.yaml

fix: Updated pnpm-lock.yaml

d2c23db

fix: Updated dependencies

2b871d5

chore: Added dcqlQuery to the siop request

f7eb79c

fix: Removed local dependencies

a50eb33

zoemaas marked this pull request as ready for review December 11, 2024 15:49

sanderPostma and others added 21 commits December 17, 2024 12:17

chore: support dcql in pd-manager and fixed version auto-increment

7504a67

chore: OID4VC version up

b7dc203

chore: lockfile

ccbd912

chore: Added withDcqlQuery to RP builder

ebda0c0

fix: Fixed type issues

c3754e6

fix: Fixed type issues and updated oid4vc dependency

f919a29

chore: fix for jsonld support

fbdad8f

chore: fix for jsonld support

8880f69

fix: Fixed the encoded presentation creation

f8a8c17

fix: Fixed merging issue

6fc5099

chore: lockfile

36c0635

chore: updated dependencies on oid4vc

e4b9a78

chore: updated rest test ports

39cf3aa

chore: lockfile

1cfce94

chore: lib updates

306c946

ronal2do reviewed Jan 7, 2025

View reviewed changes

packages/siopv2-oid4vp-op-auth/src/agent/DidAuthSiopOpAuthenticator.ts Outdated Show resolved Hide resolved

sanderPostma and others added 25 commits January 8, 2025 17:00

chore: fixed unwrapping json-string as vp_token

06944fa

refactor: updated dependencies, improved DCQL vc PD xor and added Err…

59736ac

…or case sending authentication response

refactor: Added Array.isArray() check

525c412

chore: fixed unwrapping vp_token object type

fbdce51

chore: cleanup

9a6ccb7

chore: removed new error in toWrappedVerifiablePresentation

aa4cb0a

refactor: returning Promise.reject instead of throwing error

0cd9c04

refactor: Using only Array.isArray() now

29bb78c

refactor: Using only if(authorizationRequestData.dcqlQuery) now

702a276

chore: extra comment

32bece4

chore: use AssertionProofPurpose when there is a domain but not a cha…

df3cbbd

…llenge (did:web support)

chore: Select AssertionProofPurpose when only challenge is missing

2becfb4

chore: removed TODO

1a6b469

refactor: Removed any

0991b4c

refactor: Removed any from retrieveEncodedCredential

a133247

refactor: Removed response &&

9bebc10

refactor: Removed ? from response.text()

1217bb2

refactor: Removed ? from response.headers.get('content_type') | ''

cd9d985

chore: tsconfig.json

c1a5786

chore: DCQL fixes

3f5d895

chore: DCQL lib update fixes

6202193

chore: set not send presentationDefinitions to RP instance when DCQL …

c933fcf

…is present

refactor: Updated DCQL dependency

eddadd3

refactor: Updated dependencies

3d71002

sanderPostma requested changes Jan 17, 2025

View reviewed changes

sanderPostma added 2 commits January 21, 2025 09:58

chore: fixes for PR feedback

b2fbb1d

chore: OID4VC lib update

93a7a93

ronal2do approved these changes Jan 23, 2025

View reviewed changes

Merge remote-tracking branch 'origin/develop' into feature/SPRIND-137

42ceda3

# Conflicts: # packages/siopv2-oid4vp-rp-rest-api/src/siop-api-functions.ts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/SPRIND-137 #295

feature/SPRIND-137 #295

zoemaas commented Dec 6, 2024

sanderPostma left a comment

sanderPostma Jan 17, 2025

sanderPostma Jan 17, 2025

ronal2do left a comment

feature/SPRIND-137 #295

Are you sure you want to change the base?

feature/SPRIND-137 #295

Conversation

zoemaas commented Dec 6, 2024

sanderPostma left a comment

Choose a reason for hiding this comment

sanderPostma Jan 17, 2025

Choose a reason for hiding this comment

sanderPostma Jan 17, 2025

Choose a reason for hiding this comment

ronal2do left a comment

Choose a reason for hiding this comment