Unit test provider independent ISpecFlowOutputHelper implementation (#…

…2111)

* ISpecFlowOutputHelper to write to scenario output independently of used runner plugin

* Adapt tests to handle runner specific std out

Plugins/TechTalk.SpecFlow.xUnit.SpecFlowPlugin/RuntimePlugin.cs

@@ -16,7 +16,6 @@ public void Initialize(RuntimePluginEvents runtimePluginEvents, RuntimePluginPar
         {
             runtimePluginEvents.RegisterGlobalDependencies += RuntimePluginEvents_RegisterGlobalDependencies;
             runtimePluginEvents.CustomizeTestThreadDependencies += RuntimePluginEvents_CustomizeTestThreadDependencies;
-            runtimePluginEvents.CustomizeScenarioDependencies += RuntimePluginEvents_CustomizeScenarioDependencies;
             unitTestProviderConfiguration.UseUnitTestProvider("xunit");
         }
 
@@ -31,12 +30,5 @@ private void RuntimePluginEvents_CustomizeTestThreadDependencies(object sender,
 
             container.RegisterTypeAs<XUnitTraceListener, ITraceListener>();
         }
-
-        private void RuntimePluginEvents_CustomizeScenarioDependencies(object sender, CustomizeScenarioDependenciesEventArgs e)
-        {
-            var container = e.ObjectContainer;
-
-            container.RegisterTypeAs<OutputHelper, ISpecFlowOutputHelper>();
-        }
     }
 }

TechTalk.SpecFlow/Infrastructure/DefaultDependencyProvider.cs

@@ -124,7 +124,7 @@ public virtual void RegisterTestThreadContainerDefaults(ObjectContainer testThre
         public void RegisterScenarioContainerDefaults(ObjectContainer scenarioContainer)
         {
             scenarioContainer.RegisterTypeAs<SpecFlowOutputHelper, ISpecFlowOutputHelper>();
-
+            scenarioContainer.RegisterTypeAs<SpecFlowScenarioOutputTracer, ISpecFlowScenarioOutputListener>("tracer");
         }
     }
 }

TechTalk.SpecFlow/Infrastructure/ISpecFlowScenarioOutputListener.cs

@@ -0,0 +1,7 @@
+namespace TechTalk.SpecFlow.Infrastructure
+{
+    public interface ISpecFlowScenarioOutputListener
+    {
+        void OnMessage(string message);
+    }
+}

TechTalk.SpecFlow/Infrastructure/SpecFlowOutputHelper.cs

@@ -1,21 +1,32 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
+using BoDi;
 
 namespace TechTalk.SpecFlow.Infrastructure
 {
     public class SpecFlowOutputHelper : ISpecFlowOutputHelper
     {
+        private readonly IObjectContainer _container;
+
+        public SpecFlowOutputHelper(IObjectContainer container)
+        {
+            _container = container;
+        }
+
+        private IEnumerable<ISpecFlowScenarioOutputListener> Listeners =>
+            _container.ResolveAll<ISpecFlowScenarioOutputListener>();
+
         public void WriteLine(string message)
         {
-            Console.WriteLine(message);
+            foreach (var listener in Listeners)
+            {
+                listener.OnMessage(message);
+            }
         }
 
         public void WriteLine(string format, params object[] args)
         {
-            Console.WriteLine(format, args);
+            WriteLine(string.Format(format, args));
         }
     }
 }

TechTalk.SpecFlow/Infrastructure/SpecFlowScenarioOutputTracer.cs

@@ -0,0 +1,19 @@
+using TechTalk.SpecFlow.Tracing;
+
+namespace TechTalk.SpecFlow.Infrastructure
+{
+    public class SpecFlowScenarioOutputTracer : ISpecFlowScenarioOutputListener
+    {
+        private readonly ITraceListener _traceListener;
+
+        public SpecFlowScenarioOutputTracer(ITraceListener traceListener)
+        {
+            _traceListener = traceListener;
+        }
+
+        public void OnMessage(string message)
+        {
+            _traceListener.WriteTestOutput(message);
+        }
+    }
+}

Tests/TechTalk.SpecFlow.Specs/StepDefinitions/ExecutionResultSteps.cs

@@ -104,7 +104,7 @@ public void ThenEveryScenarioHasItSIndividualContextId()
 
             foreach (var testResult in lastTestExecutionResult.TestResults)
             {
-                var contextIdLines = testResult.StdOut.SplitByString(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries).Where(s => s.Contains("Context ID"));
+                var contextIdLines = testResult.StdOut.Split(new string[] { Environment.NewLine, "\n" }, StringSplitOptions.RemoveEmptyEntries).Where(s => s.StartsWith("Context ID"));
 
                 var distinctContextIdLines = contextIdLines.Distinct();
 

changelog.txt

@@ -1,9 +1,10 @@
-3.4.4
+Changes:
++ Unit test provider independent ISpecFlowOutputHelper implementation
 
 Fixes: 
 + Support dynamic assemblies in container initialization #2110
 
-3.4
+3.4.3
 
 Changes:
 + Allow incremental builds to work correctly for projects with MSTest/NUnit/xUnit integration