fixed UpToDateChecks for feature files in MSBuild target (#1365)

* add feature files to UpToDateCheck* itemgroups * Extended UpToDateCheckBuild with "Original" Updated changelog
SpecFlowOSS · Dec 17, 2018 · 44ea742 · 44ea742
1 parent b0e03e4
commit 44ea742
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/TechTalk.SpecFlow.Tools/MsBuild/TechTalk.SpecFlow.props b/TechTalk.SpecFlow.Tools/MsBuild/TechTalk.SpecFlow.props
@@ -52,6 +52,13 @@
          - after pulling latest changes from version control with above changes
      -->
     <SpecFlowObsoleteCodeBehindFiles Include="**\*.feature.cs" Exclude="@(SpecFlowFeatureFiles->'%(CodeBehindFile)')" />
+
+    <!-- Support for Visual Studio Incremental Build
+        https://github.com/techtalk/SpecFlow/issues/1319
+     -->
+    <UpToDateCheckInput Include="@(SpecFlowFeatureFiles)" />
+    <UpToDateCheckBuild Include="@(SpecFlowFeatureFiles->'%(CodeBehindFile)')" Original="@(SpecFlowFeatureFiles)" />
+    <CustomAdditionalCompileInputs Include="@(SpecFlowFeatureFiles->'%(CodeBehindFile)')" />
   </ItemGroup>
 
 </Project>
diff --git a/Tests/TechTalk.SpecFlow.MsBuildNetSdk.IntegrationTests/CodeBehindFileGenerationTests.cs b/Tests/TechTalk.SpecFlow.MsBuildNetSdk.IntegrationTests/CodeBehindFileGenerationTests.cs
@@ -11,7 +11,7 @@ public class CodeBehindFileGenerationTests
         public void TestIfCodeBehindFilesWasGeneratedAndCompiled()
         {
             var assemblyHoldingThisClass = Assembly.GetExecutingAssembly();
-            var typeOfGeneratedFeatureFile = assemblyHoldingThisClass.GetType(nameof(DummyFeatureFileToTestMSBuildNetsdkCodebehindFileGenerationFeature));
+            var typeOfGeneratedFeatureFile = assemblyHoldingThisClass.GetType(typeof(DummyFeatureFileToTestMSBuildNetsdkCodebehindFileGenerationFeature).FullName);
             Assert.IsNotNull(typeOfGeneratedFeatureFile);
         }
     }

diff --git a/changelog.txt b/changelog.txt
@@ -1,3 +1,9 @@
+2.4.1 - 2018-??-??
+
+Fixes:
++ Visual Studio change detection integration for Net.SDK style projects via SpecFlow.Tools.MSBuild.Generation https://github.com/techtalk/SpecFlow/issues/1319
+
+
 2.4 - 2018-08-20
 New Features:
 + Added ability to convert type to same type or one of the base types https://github.com/techtalk/SpecFlow/pull/1110