Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code sharing between extensions #191

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

epresi
Copy link
Contributor

@epresi epresi commented Jul 5, 2021

In order to support VS2022 we need to refactor the existing code:

  • We should use the official Visual Studio SDK as the current one (Madskristensen.VisualStudio.SDK) is deprecated as it is legacy and is no longer maintained
  • The current implementation is not the suggested way by Microsoft. We should share the code between extensions, without referencing a Visual Studio SDK. The SDK should come from the extension project.
  • Also we have to refactor the analytics, so it could be used in the ProjectTemplateWizard.
    • Refactoring the analytics made it possible to include the Visual Studio (IDE) version in every event.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant