Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve allocation/performance of ResolutionList #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bollhals
Copy link

PR 2 extracted out of #40

Focused on ResolutionList

  • Avoid allocating a ResolutinoList if not needed
  • Improve performance of the Contains method

Performance measurements (purely this PR):
From ResolveFromType

Method Mean Error StdDev Min Max Median Rank Gen 0 Gen 1 Gen 2 Allocated
Current 223.8 ns 1.26 ns 1.18 ns 221.6 ns 225.7 ns 223.6 ns 1 0.0627 - - 296 B
Master 226.5 ns 1.43 ns 1.34 ns 224.5 ns 229.2 ns 227.1 ns 1 0.0730 - - 344 B

From ResolveFromTypeWithInnerTypes

Method Mean Error StdDev Min Max Median Rank Gen 0 Gen 1 Gen 2 Allocated
Current 319.3 ns 2.11 ns 1.97 ns 316.2 ns 322.2 ns 319.6 ns 1 0.0896 - - 424 B
Master 325.4 ns 2.31 ns 2.16 ns 322.5 ns 328.7 ns 324.9 ns 1 0.1001 - - 472 B

@bollhals
Copy link
Author

bollhals commented Oct 7, 2021

@SabotageAndi or @tzongithub what's the plan forward with this and the other PRs? What needs to be done to move forward?

@bollhals
Copy link
Author

@SabotageAndi or @tzongithub There are still a whole lot of PR's open for the Bodi, They should be fairly simple to review and it would improve the performance for it. Can we align on how to proceed with it? It's been years already since I filed them :)

@SabotageAndi
Copy link
Contributor

@bollhals Sorry that we never got to these PRs.
I left Tricentis last month, so I no longer work on SpecFlow.

@bollhals
Copy link
Author

All the best for your new opportunities! Any Idea who would be best to ping to finish this?

@SabotageAndi
Copy link
Contributor

@gasparnagy should still work for Tricentis as a freelancer.

@gasparnagy
Copy link
Collaborator

@gasparnagy should still work for Tricentis as a freelancer.

That is unfortunately not true. They haven't renewed my contract (yet?). So @bollhals I suggest contacting them at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants