Support disposal of objects returned by RegisterFactoryAs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erate a key that would make sense given that the factory is opaque -- instead just track reference objects
|
@jonathansapp Thx! Could you please also add a line about this change to the bodi.cs header (change history)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gasparnagy
BoDi does not currently provide any way to track and automatically dispose of objects returned from factory delegates. The following code changes enable this functionality while preserving the existing behavior.
The purpose of this PR is to make the changes necessary so that AutoFac lifetime scopes can be properly disposed between scenarios. See open SpecFlow issue Lifetime is Incorrect #12.
Usage:
void RegisterFactoryAs<TInterface>(Func<IObjectContainer, TInterface> factoryDelegate, string name = null, bool dispose = false)