Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webSearch and refactor testing #193

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

reflectored
Copy link
Contributor

Issue #187

  • Skip web search results for websites that failed to parse.
  • Handle the case when response has not finished with RESPONSE_TYPE_FINAL.
  • Rename response and message type appropriately.
  • Rename unit_test.py to integration_test.py, it calls the API.
  • Create unit_test.py and implement the test for the response.
  • Rename the workflow for integration tests, and add a new one for unit tests.
  • Use proper pytest fixture for creating a chatbot session.

@reflectored reflectored changed the title Fix webSearch and refactor testing #187 Fix webSearch and refactor testing Apr 11, 2024
  - Skip web search results for websites that failed to parse.
  - Handle the case when response has not finished with
    `RESPONSE_TYPE_FINAL`.
  - Rename response and message type appropriately.
  - Rename `unit_test.py` to `integration_test.py`, it calls the API.
  - Create `unit_test.py` and implement the test for the response.
  - Rename the workflow for integration tests, and add a new one for
    unit tests.
  - Use proper pytest fixture for creating a chatbot session.
@Soulter Soulter merged commit 099683b into Soulter:master Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants