Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure emphasis ends with word boundary #5

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

twouters
Copy link
Contributor

@twouters twouters commented Jan 10, 2021

Added some unit tests for reported issues.
Updated simple-markdown to 0.7.3 to include security fix.

Fixes #3

@twouters
Copy link
Contributor Author

ready for review :)

Copy link
Owner

@Sorunome Sorunome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you

Added some unit tests for reported issues.
Updated simple-markdown to 0.7.3 to include security fix.

Fixes Sorunome#3
@twouters
Copy link
Contributor Author

Undid word boundary requirements for strong and strike-through since it broke stuff

@Sorunome Sorunome merged commit 7375c30 into Sorunome:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

messages where markdown formatting overlaps slack formatting are rendered incorrectly
2 participants