Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add detection conditions of whether to correct the position #1952

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
51e73bc
tests,ci: replace yarn ci with npm ci, use typescript to run tests (#…
waynevanson Aug 7, 2020
340e8a2
docs: adds true and void return values to options.onMove (#1878)
stof Aug 17, 2020
e6110af
refactor(tests): change dir structure for tests (#1881)
waynevanson Aug 17, 2020
02be9a8
build: upgrade rollup to v2 for typescript bundling (#1882)
waynevanson Aug 17, 2020
d53f85e
build: upgrade to 1.11.0 (#1884)
waynevanson Aug 17, 2020
aa19cf3
Update CONTRIBUTING.md
waynevanson Aug 31, 2020
cc4a957
refactor: monorepo, microbundler, docs, deprecation (#1913)
waynevanson Sep 14, 2020
2aa3309
v1.11.2-alpha.0
waynevanson Sep 15, 2020
9fac640
docs: add line
waynevanson Sep 15, 2020
be69093
v1.11.2-alpha.1
waynevanson Sep 15, 2020
cd03c6c
build: add prepublishOnly to sortablejs
waynevanson Sep 15, 2020
6cd93be
v1.11.2-alpha.2
waynevanson Sep 15, 2020
608ee74
build: ensure modular is bundled on deploy
waynevanson Sep 15, 2020
a798fcf
v1.11.2-alpha.3
waynevanson Sep 15, 2020
1dff5e1
docs: update github issue templates and contribution guide (#1914)
waynevanson Sep 15, 2020
650cd1c
Readme invalid hyperlinks corrected
YogeshSinghChouhan Sep 17, 2020
62b3492
Merge pull request #1919 from YogeshSinghChouhan/fix-readme-links
waynevanson Sep 17, 2020
21c5ecf
fix(build): critical - ensure sortable deploys dist/sortable.js (#1921)
waynevanson Sep 18, 2020
c5220e2
update to v1.12.1-alpha-4 (#1925)
waynevanson Sep 20, 2020
7711207
fix(build): corrects exports for compatibility (#1926)
waynevanson Sep 21, 2020
e4dc8b0
v1.12.0
waynevanson Sep 21, 2020
5d8d44d
chore(*): uses @sortablejs instead of @sortable
waynevanson Sep 21, 2020
d7af518
fix(exports): remove packagejson#module
waynevanson Sep 21, 2020
9a08465
Merge pull request #1927 from waynevanson/fix/no_modules
waynevanson Sep 21, 2020
f74d678
v1.13.0
waynevanson Sep 21, 2020
592deff
chore(core): renames sortable to core in json
waynevanson Sep 23, 2020
6d54aa6
Support Composer package manager (#1203)
hawkeyetwolf Sep 24, 2020
6e3ac78
fix(plugins): ignore moutning duplicate plugins
waynevanson Sep 24, 2020
8d50d58
fix(util): Fix IE11 "SCRIPT16389"
waynevanson Sep 24, 2020
87c3575
Merge pull request #1932 from waynevanson/master
waynevanson Sep 24, 2020
663a466
docs(readme): fix typo (#1934)
CyrilKrylatov Sep 25, 2020
4c9db86
Fix demo link
jonagoldman Sep 30, 2020
22b80e3
docs(readme): fix link to demo page (#1939)
waynevanson Oct 1, 2020
2ad95c4
Removed Dead Link
joshgtb Oct 27, 2020
6d47ac3
Merge pull request #1950 from joshgtb/patch-1
waynevanson Oct 27, 2020
9d759a6
fix: add detection conditions of whether to correct the position
zjffun Oct 30, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,35 @@ jobs:
- checkout

- restore_cache:
name: Restore Yarn Package Cache
keys:
- v1-dependencies-{{ checksum "package.json" }}
- v1-dependencies-

- run: npm install
- yarn-packages-{{ checksum "yarn.lock" }}
- run:
name: Install Dependencies
command: yarn install --immutable

- save_cache:
name: Save Yarn Package Cache
key: yarn-packages-{{ checksum "yarn.lock" }}
paths:
- node_modules
key: v1-dependencies-{{ checksum "package.json" }}
- ~/.cache/yarn

- run:
name: Bootstrap with Lerna
command: yarn lerna bootstrap

- run: npm run build:umd
- run: yarn build:umd

- run:
name: Compatibility Test
# Only run e2e-tests if the PR
# is published by the Sortable Organization
command: |
if [ -z "$CIRCLE_PR_NUMBER" ];
then
npm run test:compat
yarn test:compat
fi
- run: npm run test
- run: yarn test

- store_test_results:
path: /tmp/test-results
15 changes: 0 additions & 15 deletions .editorconfig

This file was deleted.

69 changes: 22 additions & 47 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,73 +1,48 @@
---
name: Bug report
about: Create a report to help us improve
title: "[bug] "
about: Document a bug with a working example
title: ""
labels: ""
assignees: ""
---

<!--
_**[PLEASE READ THE CONTRIBUTION GUIDELINES HERE!](https://github.com/SortableJS/Sortable/tree/master/CONTRIBUTING.md)**_

PLEASE READ BEFORE POSTING YOUR ISSUE!
_Failure to comply may have your issue automatically closed._

If your issue is related to a framework or @types/sortablejs,
please post an issue on it's relevant repository instead:
## Reproduction

- Angular
- 2.0+: https://github.com/SortableJS/angular-sortablejs/issues
- legacy: https://github.com/SortableJS/angular-legacy-sortablejs/issues
- React
- ES2015+: https://github.com/SortableJS/react-sortablejs/issues
- mixin: https://github.com/SortableJS/react-mixin-sortablejs/issues
- Polymer: https://github.com/SortableJS/polymer-sortablejs/issues
- Knockout: https://github.com/SortableJS/knockout-sortablejs/issues
- Meteor: https://github.com/SortableJS/meteor-sortablejs/issues
<!-- Please select a codesandbox to start crafting -->

<!-- Javascript - https://codesandbox.io/s/sortablejs-javascript-jy3tl?file=/src/index.js -->
<!-- Typescript - https://codesandbox.io/s/sortablejs-typescript-6it9n?file=/src/index.ts -->

If it is a bug found from using one of these, please link to the related issue.
### Scenario

-->
\<codesandbox-url-here\>

**Describe the bug**
### Steps to Reproduce

<!-- A clear and concise description of what the bug is. -->

**To Reproduce**
Steps to reproduce the behavior:
Summary of steps if applicable.

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**

<!-- A clear and concise description of what you expected to happen. -->

**Information**

<!-- This is required. Issues without this critical information will be closed. -->
## Describe the bug

Versions - Look in your `package.json` for this information:
sortablejs = ^x.x.x
@types/sortablejs = ^x.x.x

**Additional context**
Add any other context about the problem here.

**Reproduction**
codesandbox: <your_url_here>

<!--
<!-- A clear and concise description of what the bug is. -->

Providing a codesandbox really helps us understand your issue.
Bugs with codesandboxes attached are likely to be resolved more quickly than others.
## Expected behavior

Once you've created a public codesandbox, please paste a link in here
<!-- A clear and concise description of what you expected to happen. -->

Here are some templates to get you started.
## Version

- Javascript: https://codesandbox.io/s/sortablejs-javascript-jy3tl?file=/src/index.js
- Typescript: https://codesandbox.io/s/sortablejs-typescript-6it9n?file=/src/index.ts
| package | version |
| :------------------ | :------------------ |
| `sortablejs` | `^x.x.x-?` |
| `@types/sortablejs` | `^x.x.x-?` \|\| N/A |

-->
## Additional Context
48 changes: 0 additions & 48 deletions .github/ISSUE_TEMPLATE/custom-template.md

This file was deleted.

39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/discussion.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
name: Question/Feedback
about: Ask the community a question or give us some feedback!
title: ""
labels: ""
assignees: ""
---

Please answer the following:

- What result are you trying to achieve and why?
- Where are you getting stuck at?

## Reproduction

### Scenario

<!-- Please select a codesandbox to start crafting -->

<!-- Javascript - https://codesandbox.io/s/sortablejs-javascript-jy3tl?file=/src/index.js -->
<!-- Typescript - https://codesandbox.io/s/sortablejs-typescript-6it9n?file=/src/index.ts -->

\<codesandbox-url-here\>

### Steps to Reproduce

Summary of steps if applicable.

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. Looks good

## Version

| package | version |
| :------------------ | :------------------ |
| `sortablejs` | `^x.x.x-?` |
| `@types/sortablejs` | `^x.x.x-?` \|\| N/A |
36 changes: 8 additions & 28 deletions .github/ISSUE_TEMPLATE/feature-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,16 @@ labels: ""
assignees: ""
---

<!--
_**[PLEASE READ THE CONTRIBUTION GUIDELINES HERE!](https://github.com/SortableJS/Sortable/tree/master/CONTRIBUTING.md)**_

PLEASE READ BEFORE POSTING YOUR ISSUE!
_Failure to comply may have your issue automatically closed._

If your issue is related to a framework or @types/sortablejs,
please post an issue on it's relevant repository instead:
## Summary

- Angular
- 2.0+: https://github.com/SortableJS/angular-sortablejs/issues
- legacy: https://github.com/SortableJS/angular-legacy-sortablejs/issues
- React
- ES2015+: https://github.com/SortableJS/react-sortablejs/issues
- mixin: https://github.com/SortableJS/react-mixin-sortablejs/issues
- Polymer: https://github.com/SortableJS/polymer-sortablejs/issues
- Knockout: https://github.com/SortableJS/knockout-sortablejs/issues
- Meteor: https://github.com/SortableJS/meteor-sortablejs/issues
Please answer the following questions in sentences.

- What is the feature?
- Why is having this feature important to you?
- Who else will find having this feature helpful?

If it is a bug found from using one of these, please link to the related issue.

-->

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
## Additional Context
25 changes: 0 additions & 25 deletions .jshintrc

This file was deleted.

4 changes: 4 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"tabWidth": 2,
"useTabs": false
}
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"typescript.tsdk": "/home/wayne/Documents/code/nodejs/sortable/node_modules/typescript/lib"
}
Loading