Fix S1450 FP when field is assigned value in event handler #9510
Conversation
sebastien-marichal
force-pushed
the
sma/S1450-event-handler
branch
3 times, most recently
from
81930cd
to
50ab407
Compare
sebastien-marichal
force-pushed
the
sma/S1450-event-handler
branch
from
50ab407
to
303f71c
Compare
| if (privateFields.Keys.Any(x => x.Name == node.Identifier.ValueText)) | ||
| var memberReference = GetTopmostSyntaxWithTheSameSymbol(node); | ||
| if (memberReference.Symbol is IFieldSymbol fieldSymbol | ||
| && privateFields.ContainsKey(fieldSymbol)) |
There was a problem hiding this comment.
this can go to the previous line
| && memberReference.Symbol is IMethodSymbol | ||
| && GetParentPseudoStatement(memberReference) is { } pseudoStatement) | ||
| else if (memberReference.Symbol is IMethodSymbol | ||
| && GetParentPseudoStatement(memberReference) is { } pseudoStatement) |
There was a problem hiding this comment.
same here
| { | ||
| // Adding method group to the invocation list | ||
| invocations.GetOrAdd(pseudoStatement, _ => new HashSet<ISymbol>()) | ||
| .Add(memberReference.Symbol); |
| { | ||
| // If the field is not static and is not from the current instance we | ||
| // consider the reference as read. | ||
| if (!fieldReference.Symbol.IsStatic |
There was a problem hiding this comment.
same - one line
| private void Increment(int dummy) | ||
| => _wasCalled = true; |
There was a problem hiding this comment.
| private void Increment(int dummy) | |
| => _wasCalled = true; | |
| private void Increment(int dummy) => | |
| _wasCalled = true; |
| } | ||
| } | ||
|
|
||
| private void Increment(int dummy) |
There was a problem hiding this comment.
Is it possible ever to have such method in another class/assembly?
I know that fields should be accessible in the class it self only - but just to be sure/.
There was a problem hiding this comment.
I don't think it is possible.
If the field is updated outside the class, it is out of scope of this rule, IMO. And very peculiar, I am thinking of using unsafe code or reflection.
|
|
Fixes #8239
These changes treat method groups as invocation.