Fix S1854 FN: Proper support of try/catch statements #9450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/Unmute
branch
2 times, most recently
from
9e961b0
to
ef2252a
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/LVA-Catch
branch
from
ef6a7ba
to
d01f05c
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/Unmute
branch
from
ef2252a
to
055e518
Compare
mary-georgiou-sonarsource
approved these changes
Jun 21, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4940
This is possible now, because #9448 and #9449 fixed the root cause of the FPs
Review per commit should be easier due to file-scoped namespace change