Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVA: Add support for FlowCaptureOperation and FlowCaptureReferenceOperation #9433

Merged
merged 11 commits into from
Jun 24, 2024
Merged

LVA: Add support for FlowCaptureOperation and FlowCaptureReferenceOperation #9433

merged 11 commits into from
Jun 24, 2024

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Jun 14, 2024 •
edited
Loading

Fixes #9438

@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/flowcapture-lva branch 2 times, most recently from d334d7a to 324ae0c Compare June 14, 2024 10:31
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft June 14, 2024 10:32
@mary-georgiou-sonarsource
Copy link
Contributor Author

mary-georgiou-sonarsource commented Jun 14, 2024 •
edited
Loading

@pavel-mikula-sonarsource Please take a look at the test cases. I'll need to re-check that the LI-LO are correct + I'm in the process of checking more test cases from the Security FE.
Meanwhile, I'd like some early feedback.

EDIT: I got offline feedback for the tests and it's applied.

@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/flowcapture-lva branch 5 times, most recently from 93bc7bc to fe97fcd Compare June 19, 2024 13:08
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/flowcapture-lva branch 6 times, most recently from 22cdbc9 to a4ab2da Compare June 20, 2024 11:43
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review June 20, 2024 12:04
pavel-mikula-sonarsource
pavel-mikula-sonarsource reviewed Jun 21, 2024
View reviewed changes
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
analyzers/tests/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final polishing on code changes (not art)

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
...narAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.FlowCaptureOperation.cs Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation part

analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Show resolved Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/RoslynLiveVariableAnalysis.cs Outdated Show resolved Hide resolved
pavel-mikula-sonarsource
pavel-mikula-sonarsource reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpick

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve those two open threads above

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget about this one in the cleanup:
https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&pullRequest=9433&id=sonaranalyzer-dotnet&open=AZAxQaNkFE6-BwLpTZ-p

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 3e340a6 into master Jun 24, 2024
28 of 29 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the mary/flowcapture-lva branch June 24, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
Area: CFG/SE CFG and SE related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LVA: Add support for FlowCaptureOperation and FlowCaptureReferenceOperation
2 participants
@mary-georgiou-sonarsource @pavel-mikula-sonarsource