-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LVA: Coding style cleanup #9424
Conversation
9c94507
to
60023df
Compare
70dc869
to
51a0329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Polishing
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/LiveVariableAnalysisBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/LiveVariableAnalysisBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CFG/LiveVariableAnalysis/LiveVariableAnalysisBase.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/LiveVariableAnalysis/SonarCSharpLiveVariableAnalysis.cs
Outdated
Show resolved
Hide resolved
...s/tests/SonarAnalyzer.Test/AnalysisContext/SonarAnalysisContextBaseTest.ShouldAnalyzeTree.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.cs
Show resolved
Hide resolved
...ests/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.LocalFunction.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.TryCatchFinally.cs
Outdated
Show resolved
Hide resolved
...ts/SonarAnalyzer.Test/LiveVariableAnalysis/RoslynLiveVariableAnalysisTest.TryCatchFinally.cs
Outdated
Show resolved
Hide resolved
Revert "revert test assertion" This reverts commit ba3f75c. revert assertion in test
5dbdfb7
to
028a6c3
Compare
Quality Gate passed for 'Sonar .NET Java Plugin'Issues Measures |
Quality Gate failed for 'SonarAnalyzer for .NET'Failed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just taking the dust - no functional changes or other improvements 🧹 🧹 🧹 🧹 🧹 🧹
I'll make meaningful functional cleanup changes, if needed, during actual work.