Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVA: Coding style cleanup #9424

Merged
merged 10 commits into from
Jun 14, 2024
Merged

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Jun 12, 2024

Just taking the dust - no functional changes or other improvements 🧹 🧹 🧹 🧹 🧹 🧹
I'll make meaningful functional cleanup changes, if needed, during actual work.

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polishing

Revert "revert test assertion"

This reverts commit ba3f75c.

revert assertion in test
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Failed Quality Gate failed for 'SonarAnalyzer for .NET'

Failed conditions
92.1% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 2cc6d48 into master Jun 14, 2024
30 of 31 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the mary/LVA-style-cleanup branch June 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup Improve and cleanup code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants