Fix S4507 FP: Top-level statements #8572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested changes
Jan 22, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/Hotspots/DeliveringDebugFeaturesInProduction.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/Hotspots/DeliveringDebugFeaturesInProduction.cs
Outdated
Show resolved
Hide resolved
martin-strecker-sonarsource
requested changes
Jan 23, 2024
analyzers/src/SonarAnalyzer.CSharp/Rules/Hotspots/DeliveringDebugFeaturesInProduction.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/Hotspots/DeliveringDebugFeaturesInProduction.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/Rules/Hotspots/DeliveringDebugFeaturesInProduction.cs
Outdated
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S4507-FP-top-level-statements
branch
from
cff1e6a
to
4d8aab0
Compare
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S4507-FP-top-level-statements
branch
from
4d8aab0
to
1fea206
Compare
zsolt-kolbay-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Feb 26, 2024
Comment on lines
30
to
31
| SyntaxKind.AddAccessorDeclaration, | ||
| SyntaxKind.AddAccessorDeclaration, |
There was a problem hiding this comment.
Suggested change
| SyntaxKind.AddAccessorDeclaration, | |
| SyntaxKind.AddAccessorDeclaration, | |
| SyntaxKind.AddAccessorDeclaration, |
| or SyntaxKind.WhileStatement | ||
| or SyntaxKind.ConditionalExpression | ||
| or SyntaxKind.MethodDeclaration | ||
| or SyntaxKind.SimpleLambdaExpression)) |
There was a problem hiding this comment.
Misses
or SyntaxKind.AnonymousMethodExpression
or SyntaxKind.ParenthesizedLambdaExpression
analyzers/tests/SonarAnalyzer.Test/Extensions/SyntaxNodeExtensionsTest.cs
Show resolved
Hide resolved
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/Fix-S4507-FP-top-level-statements
branch
from
751adef
to
e72fa1c
Compare
|
|
zsolt-kolbay-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
approved these changes
Feb 27, 2024
martin-strecker-sonarsource
deleted the
Zsolt/Fix-S4507-FP-top-level-statements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6772