Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my current working state of PCIe support (#425). The code only builds on x86_64 Linux (need to
#ifdef
everything for other targets) and could still be cleaned up further. Especially the page table modification is a dirty hack at best.I kept the ABI changes fairly limited, PCIe resources/DMA-ready memory is simply mapped into the unikernel at pre-determined offsets.
Currently I don't have the time to deal with it further but if somebody were to review it and point out necessary changes I'd be happy to take another look in a few weeks time.