Rewrite the "Freezing Object Properties" section #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
changed the title
|
Great, thanks for the PR. I merged it with the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13
This rewrites the existing Freezing Object Properties section to a section about marking properties as non-configurable. I'm not sure what to do with the 3rd reference since I don't have access to it...
I hope this covers the discussion in #13 accurately, changing the focus of the section to
Object.defineProperty(or, more specifically, usingconfigurable:false) and omittingObject.freeze(and related language) because of its limited and browser-specific use. I did verify that clobbering before defining fails (as written), and also checked whether you can (re)definePropertystandard document properties such asheadand it seems you can! Let me know if you think there's something to improve about my changes or if there's something else we should test 🙂Also, I included a correction for a typo I made in #12.