chore: add schema option #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dziraf
requested changes
Apr 20, 2023
| @@ -42,6 +42,10 @@ export class BaseDatabaseParser { | |||
| throw new Error('Implement "parse" method for your database parser!'); | |||
| } | |||
|
|
|||
| public async getSchemas(): Promise<string[]> { | |||
| throw new Error('Implement "getSchema" method for your database parser!'); | |||
| @@ -73,6 +73,7 @@ export class PostgresParser extends BaseDatabaseParser { | |||
| public static dialects = ['postgresql' as const]; | |||
|
|
|||
| public async parse() { | |||
| const schemaName = await this.getSchemas(); | |||
There was a problem hiding this comment.
'schemaName' is assigned a value but never used
| @@ -85,11 +86,10 @@ export class PostgresParser extends BaseDatabaseParser { | |||
| return new DatabaseMetadata(this.connectionOptions.database, resourceMap); | |||
| } | |||
|
|
|||
| public async getTables() { | |||
| const query = await this.knex.raw(` | |||
| public async getTables(schema = 'public') { | |||
There was a problem hiding this comment.
why schema arg, shouldn't it just use this.schemaName?
|
Hi, I'm the one who brought up this issue and realized that it hasn't been resolved. Regardless of the steps of contribution, if you all don't mind may I participate to solve this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.