Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSoC - Adds unique_ptr into serverCommunicationVRPN class #19

Open
wants to merge 1 commit into
base: sofaCommunication
Choose a base branch
from
Open

GSoC - Adds unique_ptr into serverCommunicationVRPN class #19

wants to merge 1 commit into from

Conversation

techytoes
Copy link

Cleaning the serverCommunicationVRPN class using unique_ptr as a part of GSOC project. Please review it @ErwanDouaille .

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

ErwanDouaille
ErwanDouaille reviewed Aug 18, 2018
View reviewed changes
applications/plugins/Communication/CMakeLists.txt
@@ -8,6 +8,9 @@ option(PLUGIN_COMMUNICATION_VRPN "Make use of the VRPN protocol" OFF)
set(COMMUNICATION_MAJOR_VERSION 1)
set(COMMUNICATION_MINOR_VERSION 0)
set(COMMUNICATION_VERSION ${COMMUNICATION_MAJOR_VERSION}.${COMMUNICATION_MINOR_VERSION})
set(CMAKE_CXX_STANDARD 14)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure it´s working with 11

@guparan guparan force-pushed the sofaCommunication branch from aec4334 to a8de521 Compare August 3, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErwanDouaille ErwanDouaille ErwanDouaille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techytoes @ErwanDouaille