Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tutorials] Tripod: cleaning #246

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Conversation

EulalieCoevoet
Copy link
Member

@EulalieCoevoet EulalieCoevoet commented Oct 23, 2023

Mainly warnings cleaning:

  • SceneCheckMissingRequiredPlugin
  • SceneCheckDuplicatedName
  • UniformMass initialisation
  • adds a new requirement to the doc
  • typos
  • UncoupledConstraintCorrection compliance warning

@EulalieCoevoet
Copy link
Member Author

@olivier-roussel If you could try that and give me feedback.

@EulalieCoevoet EulalieCoevoet changed the title [tutorials] Tripod: cleaning [wip][tutorials] Tripod: cleaning Oct 24, 2023
@EulalieCoevoet EulalieCoevoet changed the title [wip][tutorials] Tripod: cleaning [tutorials] Tripod: cleaning Oct 24, 2023
@olivier-roussel
Copy link
Contributor

Tested in a conda environment with latest SOFA master successfully until step7, where I guess I need a robot to plug

[ERROR]   [stlib3.interface.serialport] No serial port found with manufacturer = Arduino

Is that the expected behavior ?

I will try to build conda packages from this to perform a test from a SOFA installation fully from conda packages in a second step.

@EulalieCoevoet
Copy link
Member Author

Yes, because in step7 we connect the robot to the simulation.
However this code has never been tested on Windows and MacOS... I only tested it on Linux.

@olivier-roussel
Copy link
Contributor

olivier-roussel commented Oct 27, 2023

Tested successfully all steps now (thanks to your support @EulalieCoevoet).
Looks good to me (tested on Linux within a conda environment).

@damienmarchal
Copy link
Member

So do we merge ?

@olivier-roussel
Copy link
Contributor

I guess we should (on my side I can't I have no merge rights).

@EulalieCoevoet EulalieCoevoet merged commit e006531 into master Nov 6, 2023
6 of 8 checks passed
@EulalieCoevoet EulalieCoevoet deleted the pr_cleaningtripodtuto branch November 6, 2023 09:04
alxbilger added a commit to alxbilger/SoftRobots that referenced this pull request Dec 18, 2023
alxbilger added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants