-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Allow external qpOASES dependency #22
base: main
Are you sure you want to change the base?
[config] Allow external qpOASES dependency #22
Conversation
Note that 7593fd8 includes a fix that renames the directory |
We'll re-run the CI once #20 is merged and then check for merging |
934c2d3
to
f8af23c
Compare
f8af23c
to
e0bec8d
Compare
40e2adf
to
9426528
Compare
29a386a
to
0f9fb7c
Compare
0f9fb7c
to
1c23d01
Compare
@alxbilger @EulalieCoevoet This is finally ready for review. Thanks ! |
This PR enables the use of qpOASES from an external package. A similar approach to the one adopted on SOFA is proposed:
Thus, this should keep compatibility for current users.
Edit 1: The PR also adds a cmake option
SOFTROBOTSINVERSE_ENABLE_QPOASES
to enable/disable the qpOASES solver support. We now have two cmakes options for enabling/disabling each qp solver implementation: one for qpOASES and one for proxQP. Note that they are not mutually exclusive and both solvers can be enabled (selected solver can be parameterized at runtime).The CI based on Conda tests now both solvers (one CI for each solver/platform combination).
Edit 2: The PR also fixes the LCP QP solver which was still using qpOASES all the time. Now, the
LCPQPSolver
has an implementation for each QP solver, and the corresponding one is used.This is part of some necessary steps to clean the code and to go toward a conda-forge package.