Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(player/abilities): only set allow_flying on Creative mode #272

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

DataM0del
Copy link
Contributor

@DataM0del DataM0del commented Nov 14, 2024

Fixes #278

Testing

  • In Survival, press space bar 2 times and you should be falling / jumping.
  • In Creative, press space bar 2 times and you should be flying.

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt (a963bd7)
  • Code does not produce any clippy warnings cargo clippy

@Snowiiii
Copy link
Owner

Hey, @DataM0del is is currently only done for debugging purposes. If you want to could also just remove the abilities thing entirely.

@DataM0del
Copy link
Contributor Author

Okay.

@DataM0del
Copy link
Contributor Author

The linting is failing, will run cargo fmt and cargo clippy to see why.

@DataM0del
Copy link
Contributor Author

DataM0del commented Nov 14, 2024

Fixed. It was just a unused import leftover from the check.

@Snowiiii
Copy link
Owner

LGTM.
Should now also Fix: #278
Thanks @DataM0del

@Snowiiii Snowiiii merged commit 653caa0 into Snowiiii:master Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player flying in survival mode
2 participants