List command + Better message on server stop #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use the PR template |
|
Done |
|
I mean there is also the Option that the server is being stoped by CTRL+C or a SIGTERM. But thats not important for now. |
|
goat |
user622628252416
pushed a commit
to user622628252416/Pumpkin
that referenced
this pull request
Nov 7, 2024
* List command * Stop message on /stop
Snowiiii
pushed a commit
that referenced
this pull request
Nov 12, 2024
* add prototype for /give command * fix /give namespace * fix accidentally replaced text * replace block_registry with item_registry * sync added items with client * add command and command suggestion packets * Add List command (#238) * List command * Stop message on /stop * add coverter for (mostly) correctly obtaining CCommands packet payload from CommandDispatcher * fix proof of concept suggestions replacing entire command * add client side command argument suggestions * fix arg_position_2d and arg_position_3d not setting pos to block center when coordinate is an integer * add optional server side command suggestions * disable serverside suggestions for entity args * remove pumpkin test client_side_arg_parsers * use unsigned bytes for flags * add missing command arg parsers * fix entities parser flags * add player permission level * fix merge conflicts --------- Co-authored-by: user622628252416 <[email protected]> Co-authored-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Use /list in game or in console with or without online players
Use /stop and see the message
Checklist
N/A
cargo fmtcargo clippy