Add Shaped and Unshaped crafting support, as well as deserializing the entire recipe format #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryntet
force-pushed
the
registry-updates
branch
2 times, most recently
from
ff638cf
to
4fe7e17
Compare
|
Please port the recipies to 1.21.2 |
Bryntet
force-pushed
the
registry-updates
branch
from
4fe7e17
to
4572dab
Compare
|
Hi @Bryntet. Just wanted to say that 1. I really don't like the approche of having 1000 recipie files. 2. Im currently making an own extractor (see branch), Which can produce all recipes in one json file, With everything we need |
|
Yes sounds good! I will use the extractor :) |
Bryntet
force-pushed
the
registry-updates
branch
4 times, most recently
from
d429bd5
to
86f62dd
Compare
Bryntet
force-pushed
the
registry-updates
branch
2 times, most recently
from
332de47
to
134830c
Compare
Bryntet
changed the title
Bryntet
force-pushed
the
registry-updates
branch
2 times, most recently
from
69128a8
to
f60bee9
Compare
|
Ready for review. Couple of issues left: Dragging/shift-clicking is currently disabled in all crafting input/output slots items are kept currently in container even when closing it. |
Snowiiii
reviewed
Nov 11, 2024
Bryntet
force-pushed
the
registry-updates
branch
from
f60bee9
to
f697151
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add deserialization of the minecraft Recipe format. It also adds support for the Shaped and Unshaped crafting forms, accessible from a craftingtable (
/craft)