Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sift tokens #621

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

Feature/sift tokens #621

wants to merge 31 commits into from

Conversation

astrimaitis
Copy link
Contributor

No description provided.

@astrimaitis astrimaitis requested a review from TtheBC01 February 14, 2023 18:01
SnickerChar
SnickerChar reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@SnickerChar SnickerChar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I can approve or not, so I'll just comment. My biggest suggestion is to update the contracts-sdk package to match these changes, all as part of this same PR

packages/contracts/contracts/registry/Sift.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/Sift.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/Sift.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/Sift.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/registry/Sift.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnickerChar SnickerChar SnickerChar left review comments

@TtheBC01 TtheBC01 Awaiting requested review from TtheBC01

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrimaitis @SnickerChar @TtheBC01