Commits on Jul 29, 2024

1. Make Generic UnwindSafe even if its error type isn't …

   `std::io::Error` does not implement `UnwindSafe` on account
   of its ability to wrap a `Box<dyn Error + Send + Sync>`. This
   infects `Generic` which in turn infects `Channel`, which is
   inconvenient because it means you can't construct a channel
    pair, pass the receiver side to a child thread, and then
   handles panics in the child.
   
   But this is silly, because the error parameter to `Generic`
   is just a phantom. We aren't really wrapping an error at all,
   let alone downcasting it to a mutable reference and mucking
   with the referent. This patch changes the `PhantomData<E>`
   to `PhantomData<AssertUnwindSafe<E>>` so that `Generic<F, E>` can
   be `UnwindSafe` as long as `F` is.

   

   dfoxfranke committed Jul 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ee61ade
   • Browse repository at this point

   Copy the full SHA

   ee61ade View commit details

   Browse the repository at this point in the history