Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration for ssl verification #3127

Merged

Conversation

gabrielLumao
Copy link
Contributor

Added configuration, default value for it, and elasticsearch call option for SSL Verification. This allows to turn it off, for ES clients like opensearch, on local environments.

@romainruaud romainruaud added the safe to test PR can be tested label Dec 6, 2023
@romainruaud romainruaud merged commit d300dc2 into Smile-SA:2.11.x Dec 6, 2023
13 checks passed
@rbayet
Copy link
Collaborator

rbayet commented Jan 10, 2024

Hello @gabrielLumao,

Just to be sure, does the SSL verification needs to be disabled systematically if using HTTPS with OpenSearch (since that's what the configuration field says) or this is only for a local/dev OpenSearch instance ?

Regards,

@gabrielLumao
Copy link
Contributor Author

Hello @rbayet,

It was added for local/dev instances with self-signed SSL certificates.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test PR can be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants