Add support for Spring Data and update Lettuce support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drosowski
approved these changes
Jan 17, 2024
|
|
||
| class LettucePublisher(private val connection: StatefulRedisConnection<Any, Any>) : RedisPublisher { | ||
| class LettucePublisher(private val commands: RedisCommands<String, String>) : RedisPublisher { |
There was a problem hiding this comment.
I'm just wondering if the key/value is always String?
There was a problem hiding this comment.
For lettuce, the consumer can pass in a Codec that encodes and decodes what is sent to redis. So you could also have e.g. RedisCommands<ByteArray, ByteArray>. When using the instance, we need to know what the types are though so we now what we can send and we request an instance that handles Strings. I think it will be that anyways in almost all cases since all default APIs return that.
| * Returns the first message published on the given [channel] of the redis available under the [redisURI]. Waits for at | ||
| * most five seconds after executing [body] for the message to arrive. | ||
| */ | ||
| fun awaitRedisMessage(redisURI: String, channel: String, body: () -> Unit): RedisMessage { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for publishing via the
RedisTemplatefrom Spring Data Redis.spring-boot-starter-data-redisis added as acompileOnlydependency and thus is not required by consumers which do not use it.Additionally, the
LettucePublishernow takesRedisCommandsinstead of aStatefulRedisConnection. That is better from what I understand since that is what you actually are supposed to run api calls on.StatefulRedisConnectionis one of multiple options depending on the type of redis instance you are connecting to (there also existsStatefulRedisClusterConnectionfor example). This is a breaking change but you couldn't use the publisher before anyways since the generics were<Any, Any>which is impossible to satisfy so it should be fine.Lastly, I added tests for all publishers with a real redis instance using testcontainers.