Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add pact #35

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Feat/add pact #35

merged 11 commits into from
Sep 26, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Sep 3, 2024

Overview

Add Pact to Explore.Cli to generate consumer contracts

  • Adds Pact-Net V5 Beta
  • Creates standalone ExploreHttpClient
  • Adds couple of simple Pact tests to get started
  • Adds Pact to CI/CD
    • publish pacts
    • can-i-deploy
    • record-release (as multiple cli versions released at any one time)

Changes

  • Pact tests for some functions in ExploreHttpClient

    • CheckSpaceExists
    • CreateSpace
    • CheckApiExists
    • CheckConnectionExists
    • UpsertSpace
    • UpsertApi
    • UpsertConnection
    • CreateApiEntry
    • CreateApiConnection
  • CI/CD

    • Publish pacts
    • Can-I-Deploy
    • Record Deployments / Releases
    • Readme badges
      • Can I Deploy
    • Provider verification - BDCT

Related

TODO

Will raise in new PR's

  • Update to use new ExploreHttpClient, see PR

@YOU54F YOU54F mentioned this pull request Sep 13, 2024
3 tasks
@YOU54F YOU54F marked this pull request as ready for review September 13, 2024 14:12
@YOU54F
Copy link
Member Author

YOU54F commented Sep 13, 2024

Split out the consumption of the new client changes into #37

note: remaining

- UpsertSpace / UpsertApi / UpsertConnection

modified OAD for BDCT comparison. Updated included
@YOU54F
Copy link
Member Author

YOU54F commented Sep 17, 2024

Uploaded updated OAD to SwaggerHub under 1.0.0-pactflow

https://app.swaggerhub.com/apis/smartbear/explore-spaces-service/1.0.0-pactflow

Compatibility comes back as valid 🎉

updated version

Compatibility Check

This API is compatible with the following consumer contracts

Consumer applications currently in development

API is compatible with the consumer contracts from the following applications:

  • Explore Cli

current version

https://app.swaggerhub.com/apis/smartbear/explore-spaces-service/1.0.0

Compatibility Check

This API is incompatible with some consumer contracts

Consumer applications currently in development

OAS Validation Errors

  1. discriminator: requires oneOf keyword

@YOU54F YOU54F merged commit 5ec2fd0 into main Sep 26, 2024
10 checks passed
@YOU54F YOU54F deleted the feat/add_pact branch September 26, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants