-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Misspellings & Improve Performance #42
Fix Misspellings & Improve Performance #42
Conversation
All of this is untested atm, if anyone else wants to test it that would be appreciated, but I will be able to test it whenever I get home. |
I'm testing the change, if there was any problem in their operation, but part of the large-scale development, I can't validate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validation was performed on the 3 machines, no problems were found
Did you test that using mob tech properly changed everything? |
I tested the 3 machines with different tier and types, they worked correctly. |
lag tripled in version #25 supreme version supreme #23 -> https://prnt.sc/2snKITZHsMC4 timings paper: https://timings.aikar.co/dev/?id=bd1a2c9d88b34f72b2eeb89069bb6c1c timings spark: https://spark.lucko.me/d8tUnWFBSx |
Try with the new version, lag should be le gone |
there is still a problem in supreme, see timings paper: https://timings.aikar.co/dev/?id=610ae37862014835a87df55eb59fc430 image 1: https://prnt.sc/5SWy-Meyadto my slimefun always stays at 20% in plugins when i update supreme it stays between 60% - 67% i don't know what's going on but these updates in supreme increased the performance a lot supreme version #26 |
This PR basically replaces #37
Helps with #36
The tech generator performance issue is not as easy to solve as most of the problems areas are essential to the machine and are laggy from slimefun method calls.