Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Misspellings & Improve Performance #42

Conversation

JustAHuman-xD
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD commented Apr 12, 2023

This PR basically replaces #37
Helps with #36
The tech generator performance issue is not as easy to solve as most of the problems areas are essential to the machine and are laggy from slimefun method calls.

@JustAHuman-xD JustAHuman-xD changed the title Fix Misspellings & Improve Tech Mutation Performance Fix Misspellings & Improve Performance Apr 12, 2023
@JustAHuman-xD
Copy link
Contributor Author

All of this is untested atm, if anyone else wants to test it that would be appreciated, but I will be able to test it whenever I get home.

@RelativoBR
Copy link
Collaborator

I'm testing the change, if there was any problem in their operation, but part of the large-scale development, I can't validate

@RelativoBR RelativoBR self-requested a review April 12, 2023 18:02
Copy link
Collaborator

@RelativoBR RelativoBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validation was performed on the 3 machines, no problems were found

@JustAHuman-xD
Copy link
Contributor Author

Did you test that using mob tech properly changed everything?

@RelativoBR
Copy link
Collaborator

I tested the 3 machines with different tier and types, they worked correctly.

@RelativoBR RelativoBR merged commit 95dacc1 into Slimefun-Addon-Community:main Apr 12, 2023
@RelativoBR RelativoBR mentioned this pull request Apr 12, 2023
@SrMonsterYT
Copy link

SrMonsterYT commented Apr 13, 2023

lag tripled in version #25 supreme

version supreme #23 -> https://prnt.sc/2snKITZHsMC4
version supreme #25 -> https://prnt.sc/mWR7vm7wOqb9

timings paper: https://timings.aikar.co/dev/?id=bd1a2c9d88b34f72b2eeb89069bb6c1c

timings spark: https://spark.lucko.me/d8tUnWFBSx

@JustAHuman-xD

@JustAHuman-xD
Copy link
Contributor Author

Try with the new version, lag should be le gone

@SrMonsterYT
Copy link

SrMonsterYT commented Apr 14, 2023

Try with the new version, lag should be le gone

there is still a problem in supreme, see

timings paper: https://timings.aikar.co/dev/?id=610ae37862014835a87df55eb59fc430
spark timings: https://spark.lucko.me/w76fiWIMTG

image 1: https://prnt.sc/5SWy-Meyadto
image 2: https://prnt.sc/iMG9mFUeBuRo

my slimefun always stays at 20% in plugins when i update supreme it stays between 60% - 67% i don't know what's going on but these updates in supreme increased the performance a lot

supreme version #26
I'm going back to version #23 where there is no tps drop and no increase in slimefun

@JustAHuman-xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants