Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enchantment glint set #94

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enchantment glint set #94

wants to merge 2 commits into from

Conversation

ProfElements
Copy link

Short Description

Additions/Changes/Removals

Related Issues

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@ProfElements
Copy link
Author

I can not test this currently as I'm not running a 1.20.5 server so if anyone could confirm it works properly that would be cool.

J3fftw1
J3fftw1 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But will block this till 1.20.5 support in slimefun

@ybw0014
Copy link
Member

ybw0014 commented Apr 29, 2024

dropping support for 1.20.4 and below?

@J3fftw1
Copy link
Contributor

J3fftw1 commented Apr 29, 2024

dropping support for 1.20.4 and below?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J3fftw1 J3fftw1 J3fftw1 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ProfElements @ybw0014 @J3fftw1