Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed interaction with Brewery cauldrons #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TristanVdElzen
Copy link

Cauldrons for making brews in the Brewery plugin can now take ExoticGarden fruits again. Regular cauldrons will not be interactable, preventing fruit placement and bush duplication exploit. When brewery is not installed isBreweryCauldron() returns false causing it not to be interactable, as expected.

Fixes:

Cauldrons for making brews in the Brewery plugin can now take ExoticGarden fruits again. Regular cauldrons will not be interactable, preventing fruit placement and bush duplication exploit. When brewery is not installed `isBreweryCauldron()` returns false causing it not to be interactable, as expected.
@EpicPlayerA10
Copy link

I think it will be simply solved by only removing cauldon from isInteractable list.

@TristanVdElzen
Copy link
Author

I think it will be simply solved by only removing cauldon from isInteractable list.

No. When it is a regular cauldron isInteractable() should return false as otherwise you would place the fruits on the cauldron, but when it is a cauldron from the Brewery plugin it should return true as otherwise the fruit will be eaten instead of inserted. This is why I've created a separate method for exactly this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants