Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST-6210] Allow Node >=18 in engines config #3726

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

dominicfraser
Copy link
Contributor

@dominicfraser dominicfraser commented Jan 21, 2025

As we have with NPM, use >= to allow consumers on newer versions of Node to install Backpack.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

Visit https://backpack.github.io/storybook-prs/3726 to see this build running in a browser.

@dominicfraser dominicfraser added the patch Patch production bug label Jan 21, 2025
@dominicfraser dominicfraser marked this pull request as ready for review January 21, 2025 16:31
@olliecurtis olliecurtis merged commit 4c4d660 into main Jan 21, 2025
9 of 10 checks passed
@olliecurtis olliecurtis deleted the ST-6210_engines branch January 21, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants