Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clamps to wherever they might be needed in DungeonScore #1035

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add clamps to wherever they might be needed in DungeonScore #1035

merged 3 commits into from
Oct 31, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Oct 28, 2024

Hoping this alleviates #958.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Oct 28, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but some of the clamps are getting very complicated. I would extract the first parameters of clamp into separate variables.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 28, 2024
@kevinthegreat1 kevinthegreat1 added the bug Something isn't working label Oct 28, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Oct 28, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 31, 2024
@kevinthegreat1 kevinthegreat1 merged commit 1d47b31 into SkyblockerMod:master Oct 31, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Oct 31, 2024
@Emirlol Emirlol deleted the dungeon-score-clamping branch October 31, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Emirlol @kevinthegreat1 @LifeIsAParadox