Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random fixes #1006

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Random fixes #1006

merged 8 commits into from
Sep 26, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Sep 22, 2024 •
edited
Loading

  • Refactor format time
  • Update pet tier parsing
  • Add warning for empty quick nav commands
  • Refactor StatusBarTracker and fix a bug with updating
    • Make health bar update every tick
    • Make speed bar update every tick instead of every frame
    • Clean up the regex and logic
  • Fix BazaarPriceTooltip crash in sacks

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Sep 22, 2024
@kevinthegreat1 kevinthegreat1 added the bug Something isn't working label Sep 22, 2024
viciscat
viciscat approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool I think

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 24, 2024
AzureAaron
AzureAaron approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@AzureAaron AzureAaron added the crash This is a crash label Sep 26, 2024
@AzureAaron AzureAaron merged commit 9bccc63 into SkyblockerMod:master Sep 26, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Sep 26, 2024
@kevinthegreat1 kevinthegreat1 deleted the random-fixes branch September 27, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viciscat viciscat viciscat approved these changes

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working crash This is a crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinthegreat1 @viciscat @AzureAaron @LifeIsAParadox