Bench: only show packages which took at least 1s in render_results table

SkySkimmer · Jan 9, 2025 · 90bf0cb · 90bf0cb
1 parent 8eacf86
commit 90bf0cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/dev/bench/bench.sh b/dev/bench/bench.sh
@@ -611,8 +611,8 @@ $coq_opam_package (in $RUNNER)"
         :
     else
 
-        echo "DEBUG: $render_results "$log_dir" $num_of_iterations 0 user_time_pdiff $installable_coq_opam_packages"
-        rendered_results="$($render_results "$log_dir" $num_of_iterations 0 user_time_pdiff $installable_coq_opam_packages)"
+        echo "DEBUG: $render_results "$log_dir" $num_of_iterations 1 user_time_pdiff $installable_coq_opam_packages"
+        rendered_results="$($render_results "$log_dir" $num_of_iterations 1 user_time_pdiff $installable_coq_opam_packages)"
         echo "${rendered_results}"
         # update the comment
         coqbot_update_comment "" "${rendered_results}" ""
@@ -719,8 +719,8 @@ if [ -z "$installable_coq_opam_packages" ]; then
     exit 1
 fi
 
-echo "DEBUG: $render_results $log_dir $num_of_iterations 0 user_time_pdiff $installable_coq_opam_packages"
-rendered_results="$($render_results "$log_dir" $num_of_iterations 0 user_time_pdiff $installable_coq_opam_packages)"
+echo "DEBUG: $render_results $log_dir $num_of_iterations 1 user_time_pdiff $installable_coq_opam_packages"
+rendered_results="$($render_results "$log_dir" $num_of_iterations 1 user_time_pdiff $installable_coq_opam_packages)"
 echo "${rendered_results}"
 echo "${rendered_results}" > $timings/bench_summary
 

diff --git a/dev/bench/render_results.ml b/dev/bench/render_results.ml
@@ -231,7 +231,7 @@ coq_opam_packages
 
 |> CList.filter
      (fun (_, new_t, old_t, _) ->
-        minimal_user_time <= new_t.user_time && minimal_user_time <= old_t.user_time)
+        minimal_user_time <= new_t.user_time || minimal_user_time <= old_t.user_time)
 
 (* Below we take the measurements and format them to stdout. *)