Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity patch for abandoned addons. #7356

Merged

Conversation

Moderocky
Copy link
Member

Description

Despite the legacy converters class being scheduled for removal several years ago, some addons have not removed code depending on it.
As this class is (was) removed in 2.10, these addons will fail to load unless they are recompiled.

Many addons are unaffected by this, since the alternative has been around for a long time.

Since this issue seemed quite widespread (based on a GitHub all-repositories search),
I have added a temporary 'patch' to make these addons load, using a stub of the removed class. The stub will print a large warning if an outdated addon tries to use the class, and a large amount of its (unsupported) functionality is no longer available, but it does mean that most outdated addons, e.g. skript-gui, will still load.

These stubs have the maximum amount of compile-time warnings and errors I can put on them, and they will be removed in future. This is not a permanent fix, just a temporary motivation for developers who have not updated their work in time.

Affected Classes

  • ch.njol.skript.registrations.Converters
  • ch.njol.skript.classes.Converter

Example Warning

image

(This will presumably be red on a colour-supporting terminal.)

@Moderocky Moderocky added up for debate When the decision is yet to be debated on the issue in question housekeeping Housekeeping-related issue or task. 2.10 Targeting a 2.10.X version release labels Jan 2, 2025
@Moderocky Moderocky marked this pull request as ready for review January 3, 2025 13:46
@Moderocky Moderocky force-pushed the compatiblity-patch-converter branch from 48c4fd0 to 6f08794 Compare January 12, 2025 16:53
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine with the changes. I will do some further in-game testing as well.

src/main/java/ch/njol/skript/util/Utils.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/registrations/Converters.java Outdated Show resolved Hide resolved
@Moderocky Moderocky force-pushed the compatiblity-patch-converter branch from e4a983f to d6fc417 Compare January 13, 2025 15:32
@Moderocky Moderocky merged commit 0a441ce into SkriptLang:dev/feature Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release housekeeping Housekeeping-related issue or task. up for debate When the decision is yet to be debated on the issue in question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants