Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(komga): Non-English search not working #782

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dyphire
Copy link
Contributor

@dyphire dyphire commented Oct 20, 2024

Checklist:

  • Updated source's version for individual source changes
  • Updated all sources' versions for template changes
  • Set appropriate nsfw value
  • Did not change id even if a source's name or language were changed
  • Tested the modifications by running it on the simulator or a test device

Related Issues

Close #659

Screenshots

Before After
image image

Copy link
Owner

@Skittyblock Skittyblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you fix the clippy warning.

this still works for searches containing special characters like & and spaces, correct?

@dyphire
Copy link
Contributor Author

dyphire commented Oct 21, 2024

make sure you fix the clippy warning.

Changed as suggested by clippy.

this still works for searches containing special characters like & and spaces, correct?

Searching for special characters has never worked correctly because komga doesn't do url decoding on the search response. That's why non-English searches didn't work before, because aidoku encodes the url and komga doesn't decode the url accordingly. This is a limitation of komga.

@dyphire
Copy link
Contributor Author

dyphire commented Oct 22, 2024

Any more problems here?

Here, too.

@Skittyblock Skittyblock merged commit 60a7f4d into Skittyblock:main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Komga source not support Non-English search
2 participants